From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ns1.suse.de ([195.135.220.2] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1JKTex-0001Y7-Ca for kexec@lists.infradead.org; Thu, 31 Jan 2008 07:16:38 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id B120F26F3C for ; Thu, 31 Jan 2008 08:16:27 +0100 (CET) Date: Thu, 31 Jan 2008 08:16:25 +0100 From: Bernhard Walle Subject: Re: Kexec command line length Message-ID: <20080131071625.GA11164@suse.de> References: <20080128212910.GA21889@suse.de> <20080129010122.GA11935@hmsreliant.think-freely.org> <20080129154104.GA12219@redhat.com> <20080129181701.GB535@suse.de> <20080129195753.GB21530@hmsreliant.think-freely.org> <20080130205323.GA15415@redhat.com> <20080130205947.GA5660@hmsendeavour.rdu.redhat.com> <20080130210815.GB15415@redhat.com> <20080130211834.GC5660@hmsendeavour.rdu.redhat.com> <20080130214551.GC15415@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20080130214551.GC15415@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org+dwmw2=infradead.org@lists.infradead.org To: kexec@lists.infradead.org * Vivek Goyal [2008-01-30 22:45]: > > No. 2.04 is really old. As per boot.txt, it was introduced in 2.6.14. > > Anyway, thinking about it more, Large command lines were introduced in > 2.6.21 kernel (for both i386 and x86_64). cmdline_size was introduced > in 2.6.22 (for both i386 and x86_64). So how about following test > condition for both the arch. > > if (boot_protocol >= 2.06) > error message based on cmdline_size field > else > Warn user if command line is more than 256 but continue to work. > Let the user know that it is not known if kernel being loaded > supports command line size greater than 256. Command line will > be truncated by destination kernel if it does not support large > command lines. User is taking a chance Yes, I also think that's sufficient. Bernhard _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec