From: Ingo Molnar <mingo@elte.hu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"H. Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, lguest <lguest@ozlabs.org>
Subject: Re: [PATCH] lguest: fix mis-merge against hpa's TSS renaming
Date: Thu, 31 Jan 2008 10:23:41 +0100 [thread overview]
Message-ID: <20080131092341.GA10841@elte.hu> (raw)
In-Reply-To: <200801311800.48359.rusty@rustcorp.com.au>
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> --- a/drivers/lguest/x86/core.c Thu Jan 31 14:50:43 2008 +1100
> +++ b/drivers/lguest/x86/core.c Thu Jan 31 17:58:44 2008 +1100
> @@ -94,7 +94,7 @@ static void copy_in_guest_info(struct lg
> /* Set up the two "TSS" members which tell the CPU what stack to use
> * for traps which do directly into the Guest (ie. traps at privilege
> * level 1). */
> - pages->state.guest_tss.esp1 = cpu->esp1;
> + pages->state.guest_tss.sp1 = cpu->esp1;
btw., could you perhaps (later on) rename it to ->sp1, so that all the
register namings are consistent in the x86 architecture? Might be handy
for lguest-64 as well :-)
Ingo
next prev parent reply other threads:[~2008-01-31 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 7:00 [PATCH] lguest: fix mis-merge against hpa's TSS renaming Rusty Russell
2008-01-31 9:23 ` Ingo Molnar [this message]
2008-01-31 9:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131092341.GA10841@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.