All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH] x86_64: fix comments in vmlinux_64.lds
Date: Thu, 31 Jan 2008 13:35:03 +0100	[thread overview]
Message-ID: <20080131123503.GG12571@elte.hu> (raw)
In-Reply-To: <200801302348.37990.yinghai.lu@sun.com>


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

>  ENTRY(startup_64)
>  SECTIONS
>  {
> -	/* Be careful parts of head_64.S assume startup_64 is at
> +	/* Be careful parts of head_64.S assume startup_32 is at
>  	 * address 0.
>  	 */
>  	. = 0;

but this linker script rule is about startup_64, not about startup_32.

startup_32 does exist on 64-bit too (and is 32-bit code), but it's 
linked to a different address that is not 0:

 ffffffff806c23c0 r startup_32

startup_64 is at offset 0:

 ffffffff80200000 T startup_64

So your patch looks wrong to me.

	Ingo

  reply	other threads:[~2008-01-31 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31  7:48 PATCH] x86_64: fix comments in vmlinux_64.lds Yinghai Lu
2008-01-31 12:35 ` Ingo Molnar [this message]
2008-01-31 19:12   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131123503.GG12571@elte.hu \
    --to=mingo@elte.hu \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.