All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Guennadi Liakhovetski
	<g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [RFC PATCH 3/8] Add PCA9536 4 bit I2C GPIO extender support to the pca9539 GPIO driver
Date: Thu, 31 Jan 2008 15:56:04 -0800	[thread overview]
Message-ID: <200801311556.05395.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0801311425300.6494-0199iw4Nj15frtckUFj5Ag@public.gmane.org>

On Thursday 31 January 2008, Guennadi Liakhovetski wrote:
> On Thu, 31 Jan 2008, David Brownell wrote:
> 
> > > > > > +#ifndef NO_GPIO
> > > > > > +#define NO_GPIO                        ((unsigned int)-1)
> > > > > > +#endif
> > > > > > +
> > > > > 
> > > > > I don't understand this.
> > > > 
> > > > Me either; *ANY* negative number is invalid as a GPIO number,
> > > > not just "-1"...
> > > 
> > > Ok, this one should rather go into a separate patch. I'd like to have such 
> > > a macro to check whether the platform is using a GPIO with this specific 
> > > camera or not. Similar to NO_IRQ.
> > 
> > Then maybe there should be an is_valid_gpio() predicate.
> > Anything not between 0..MAX_INT would fail.  And there
> > should be a Documentation/gpio.txt update to match.
> 
> hm, but if you deliberately want an invalid gpio number?

Any negative number suffices -- like "-EINVAL".  But that's a
separate problem from the one you said you wanted to solve...

- Dave

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

  parent reply	other threads:[~2008-01-31 23:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0801231646090.4932@axis700.grange>
2008-01-23 17:41 ` [RFC PATCH 3/8] Philips PCA9536 4 bit I2C GPIO extender driver Guennadi Liakhovetski
     [not found]   ` <Pine.LNX.4.64.0801231820060.4932-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-27 21:45     ` Jean Delvare
2008-01-27 22:27       ` [i2c] " Guennadi Liakhovetski
     [not found]       ` <20080127224559.4eed7cea-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-01-28  6:18         ` David Brownell
2008-01-30 16:48           ` [i2c] [RFC PATCH 3/8] Add PCA9536 4 bit I2C GPIO extender support to the pca9539 GPIO driver Guennadi Liakhovetski
2008-01-31  1:31             ` eric miao
     [not found]               ` <f17812d70801301731n62597f12kc151d01c320e3dec-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-31  4:52                 ` David Brownell
2008-01-31 10:13                   ` [i2c] " Guennadi Liakhovetski
     [not found]                     ` <Pine.LNX.4.64.0801311025210.6494-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 10:48                       ` David Brownell
2008-01-31 11:30                         ` [i2c] " Guennadi Liakhovetski
     [not found]                           ` <Pine.LNX.4.64.0801311204280.6494-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 11:46                             ` David Brownell
2008-01-31 11:49                             ` David Brownell
2008-01-31 13:30                         ` [i2c] " Guennadi Liakhovetski
     [not found]                           ` <Pine.LNX.4.64.0801311425300.6494-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2008-01-31 23:56                             ` David Brownell [this message]
     [not found] ` <Pine.LNX.4.64.0801272006570.5942@axis700.grange>
2008-02-04 12:51   ` [RFC PATCH 0/8] Patch series to add soc_camera virtual v4l2 and its users Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801311556.05395.david-b@pacbell.net \
    --to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
    --cc=g.liakhovetski-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=video4linux-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.