From: Olof Johansson <olof@lixom.net>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: torvalds@linux-foundation.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Set dma_data correctly for direct_ops on pasemi
Date: Thu, 31 Jan 2008 10:18:05 -0600 [thread overview]
Message-ID: <20080131161805.GA10340@lixom.net> (raw)
In-Reply-To: <1201783096.4147.3.camel@concordia>
On Thu, Jan 31, 2008 at 11:38:16PM +1100, Michael Ellerman wrote:
> On Thu, 2008-01-31 at 00:41 -0600, Olof Johansson wrote:
> > More late-caught fallout from the mainline merge. The patch:
> >
> > [POWERPC] Use archdata.dma_data in dma_direct_ops and add the offset
> >
> > "Now that all platforms using dma_direct_offset setup the
> > archdata.dma_data correctly, ..."
> >
> > Nope -- the pasemi iommu setup code that disables translation on the
> > DMA pci device didn't set dma_data correctly.
> >
> > The below patch is needed, please merge as soon as practical. Thanks!
>
> Sorry about that.
>
> I'm confused though, didn't your device come from alloc_pci_dev() which
> kzalloc()s the pci_dev which contains the archdata which contains the
> dma_data, ie. dma_data will already be 0?
Yeah, I don't see how my patch could work (but it did), since the code
falls through and overwrites dma_data with the pointer to the table,
just as before. Weird, I did test it last night. See new patch.
-Olof
next prev parent reply other threads:[~2008-01-31 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 1:23 Please pull powerpc.git for-2.6.25 branch Paul Mackerras
2008-01-31 3:34 ` [PATCH] [POWERPC] Fix compilation for CONFIG_DEBUGGER=n and CONFIG_KEXEC=y Olof Johansson
2008-01-31 6:41 ` [PATCH] [POWERPC] Set dma_data correctly for direct_ops on pasemi Olof Johansson
2008-01-31 12:38 ` Michael Ellerman
2008-01-31 16:18 ` Olof Johansson [this message]
2008-01-31 16:25 ` [PATCH v2] " Olof Johansson
2008-01-31 23:50 ` [PATCH] [POWERPC] pasemi: Fix thinko in dma_direct_ops setup Olof Johansson
2008-02-01 7:56 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131161805.GA10340@lixom.net \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.