From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JKfd3-00009a-Od for mharc-grub-devel@gnu.org; Thu, 31 Jan 2008 15:03:21 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JKfd2-00009J-6z for grub-devel@gnu.org; Thu, 31 Jan 2008 15:03:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JKfd0-00008z-PO for grub-devel@gnu.org; Thu, 31 Jan 2008 15:03:19 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKfd0-00008w-Jt for grub-devel@gnu.org; Thu, 31 Jan 2008 15:03:18 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JKfd0-0004f7-6A for grub-devel@gnu.org; Thu, 31 Jan 2008 15:03:18 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JKfb5-0006w3-5U for grub-devel@gnu.org; Thu, 31 Jan 2008 21:01:21 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JKfYd-0007Zp-0g for grub-devel@gnu.org; Thu, 31 Jan 2008 20:58:47 +0100 Date: Thu, 31 Jan 2008 20:58:47 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080131195846.GA29048@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] btree support in xfs driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2008 20:03:20 -0000 On Fri, Feb 01, 2008 at 03:40:20AM +0800, Bean wrote: > Hi, > > I add btree support for the xfs driver, and fix a few bugs. Now i' m > able to list a directory of over 5000 files, please test it. You're truly impressive... One comment: > { > struct grub_fshelp_node *diro = (struct grub_fshelp_node *) dir; > - auto int call_hook (grub_uint64_t ino, char *filename); > + auto int __attribute__ ((regparm(1))) call_hook (grub_uint64_t ino, > char *filename); > > - int call_hook (grub_uint64_t ino, char *filename) > + int __attribute__ ((regparm(1))) call_hook (grub_uint64_t ino, char > *filename) would this break on non-i386 ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)