All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_64: remove unneeded round_up
Date: Thu, 31 Jan 2008 23:53:25 +0100	[thread overview]
Message-ID: <20080131225325.GA27874@elte.hu> (raw)
In-Reply-To: <200801311455.48573.yinghai.lu@sun.com>


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> -	if (mem != -1L) {
> -		mem = round_up(mem, align);
> +	if (mem != -1L)
>  		return __va(mem);
> -	}

thanks, applied.

It even reduces the size of the kernel a tiny bit:

   text    data     bss     dec     hex filename
   2963    4149    4352   11464    2cc8 numa_64.o.before
   2949    4149    4352   11450    2cba numa_64.o.after

and it's always a good sign to kernel quality when patches (that change 
functionality) have that effect :)

	Ingo

      reply	other threads:[~2008-01-31 22:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200801291113.35974.yinghai.lu@sun.com>
2008-01-29 19:14 ` [PATCH 2/4] x86_64: make early_node_mem return align address v2 Yinghai Lu
2008-01-30  2:39   ` Yinghai Lu
2008-01-30  3:28   ` [PATCH 2/2] x86_64: make bootmap_start page align v3 Yinghai Lu
2008-01-30 18:51     ` PATCH] x86_64: make bootmap_start page align v4 Yinghai Lu
2008-01-30 19:08       ` Andi Kleen
2008-01-30 20:15         ` Yinghai Lu
2008-01-30 23:23           ` [PATCH] x86_64: make bootmap_start page align v5 Yinghai Lu
2008-01-30 23:50             ` Yinghai Lu
2008-01-31  3:02           ` PATCH] x86_64: make bootmap_start page align v4 Andi Kleen
2008-01-31  3:29             ` Yinghai Lu
2008-01-31 13:07       ` Ingo Molnar
2008-01-29 19:15 ` [PATCH 3/4] x86_64: Use early reservation for early node data Yinghai Lu
2008-01-29 19:16 ` [PATCH 4/4] x86_64: increse MAX_EARLY_RES for NODE_DATA and bootmap Yinghai Lu
2008-01-30  2:57   ` Andi Kleen
2008-01-30  3:25     ` Yinghai Lu
2008-01-31 13:24       ` Ingo Molnar
2008-01-31 13:34         ` Andi Kleen
2008-01-31 20:37           ` [PATCH] x86_64: add debug name for early_res Yinghai Lu
2008-01-31 20:44             ` [PATCH] x86_64: make bootmap_start page align v6 Yinghai Lu
2008-01-31 21:05               ` Ingo Molnar
2008-01-31 21:30                 ` Yinghai Lu
2008-01-31 22:55                 ` [PATCH] x86_64: remove unneeded round_up Yinghai Lu
2008-01-31 22:53                   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131225325.GA27874@elte.hu \
    --to=mingo@elte.hu \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.