All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: krzysztof.h1@poczta.fm
Cc: jsimmons@infradead.org, miki@dds.nl,
	linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com
Subject: Re: [Bugme-new] [Bug 9847] New: i810fb: module parameter 'mode_option' inconsistent with other framebuffer modules
Date: Thu, 31 Jan 2008 23:32:32 -0800	[thread overview]
Message-ID: <20080131233232.a7bf51d5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080201070131.27F842BD8B5@f25.poczta.interia.pl>

On 01 Feb 2008 08:01:30 +0100 krzysztof.h1@poczta.fm wrote:

> > On Tue, 29 Jan 2008 21:02:39 -0800 (PST) bugme-daemon@bugzilla.kernel.org
> > wrote:
> > > Problem Description: While all other framebuffer modules use the option
> > > "mode=..." to specify a modedb-style video mode, i810fb uses the
> > non-standard
> > > "mode_option=..." 
> 
> The attached patch should fix it.
> --
> 
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch changes the option "mode_option" into "mode".
> 

Thanks.

> -module_param(mode_option, charp, 0);
> -MODULE_PARM_DESC(mode_option, "Specify initial video mode");
> +module_param(mode, charp, 0);
> +MODULE_PARM_DESC(mode, "Specify initial video mode");

But can we retain the old option as well, to avoid breaking people's
existing setups?


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-02-01  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01  7:01 [Bugme-new] [Bug 9847] New: i810fb: module parameter 'mode_option' inconsistent with other framebuffer modules krzysztof.h1
2008-02-01  7:32 ` Andrew Morton [this message]
2008-02-02  4:18   ` Alain Kalker
2008-02-02  4:37     ` Andrew Morton
2008-02-02  5:27       ` Alain Kalker
     [not found] <bug-9847-10286@http.bugzilla.kernel.org/>
2008-01-30  5:33 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131233232.a7bf51d5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adaplas@gmail.com \
    --cc=jsimmons@infradead.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=miki@dds.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.