From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765437AbYBACiZ (ORCPT ); Thu, 31 Jan 2008 21:38:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752825AbYBACiS (ORCPT ); Thu, 31 Jan 2008 21:38:18 -0500 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:46743 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752446AbYBACiR (ORCPT ); Thu, 31 Jan 2008 21:38:17 -0500 Date: Thu, 31 Jan 2008 20:38:15 -0600 From: Robin Holt To: Christoph Lameter Cc: Andrea Arcangeli , Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com Subject: Re: mmu_notifier: invalidate_range for move_page_tables Message-ID: <20080201023815.GC26420@sgi.com> References: <20080131045750.855008281@sgi.com> <20080131045812.785269387@sgi.com> <20080131123118.GK7185@v2.random> <20080201001355.GU7185@v2.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 31, 2008 at 05:57:25PM -0800, Christoph Lameter wrote: > Move page tables also needs to invalidate the external references > and hold new references off while moving page table entries. I must admit to not having spent any time thinking about this, but aren't we moving the entries from one set of page tables to the other, leaving the pte_t entries unchanged. I guess I should go look, but could you provide a quick pointer in the proper direction as to why we need to recall externals when the before and after look of these page tables will have the same information for the TLBs. Thanks, Robin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Holt Subject: Re: mmu_notifier: invalidate_range for move_page_tables Date: Thu, 31 Jan 2008 20:38:15 -0600 Message-ID: <20080201023815.GC26420@sgi.com> References: <20080131045750.855008281@sgi.com> <20080131045812.785269387@sgi.com> <20080131123118.GK7185@v2.random> <20080201001355.GU7185@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Peter Zijlstra , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, steiner-sJ/iWh9BUns@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Avi Kivity , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org, Robin Holt To: Christoph Lameter Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Jan 31, 2008 at 05:57:25PM -0800, Christoph Lameter wrote: > Move page tables also needs to invalidate the external references > and hold new references off while moving page table entries. I must admit to not having spent any time thinking about this, but aren't we moving the entries from one set of page tables to the other, leaving the pte_t entries unchanged. I guess I should go look, but could you provide a quick pointer in the proper direction as to why we need to recall externals when the before and after look of these page tables will have the same information for the TLBs. Thanks, Robin ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 31 Jan 2008 20:38:15 -0600 From: Robin Holt Subject: Re: mmu_notifier: invalidate_range for move_page_tables Message-ID: <20080201023815.GC26420@sgi.com> References: <20080131045750.855008281@sgi.com> <20080131045812.785269387@sgi.com> <20080131123118.GK7185@v2.random> <20080201001355.GU7185@v2.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andrea Arcangeli , Robin Holt , Avi Kivity , Izik Eidus , kvm-devel@lists.sourceforge.net, Peter Zijlstra , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com List-ID: On Thu, Jan 31, 2008 at 05:57:25PM -0800, Christoph Lameter wrote: > Move page tables also needs to invalidate the external references > and hold new references off while moving page table entries. I must admit to not having spent any time thinking about this, but aren't we moving the entries from one set of page tables to the other, leaving the pte_t entries unchanged. I guess I should go look, but could you provide a quick pointer in the proper direction as to why we need to recall externals when the before and after look of these page tables will have the same information for the TLBs. Thanks, Robin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org