From: Andi Kleen <andi@firstfloor.org>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
Patrick McHardy <kaber@trash.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] Disable TSO for non standard qdiscs
Date: Fri, 1 Feb 2008 06:01:46 +0100 [thread overview]
Message-ID: <20080201050146.GD10720@one.firstfloor.org> (raw)
In-Reply-To: <47A230A8.7080100@gmail.com>
On Thu, Jan 31, 2008 at 09:33:44PM +0100, Jarek Poplawski wrote:
> Andi Kleen wrote, On 01/31/2008 08:34 PM:
>
> >> TSO by nature is bursty. But disabling TSO without the option of having
> >> it on or off to me seems to aggressive. If someone is using a qdisc
> >> that TSO is interfering with the effectiveness of the traffic shaping,
> >> then they should turn off TSO via ethtool on the target device. Some
> >
> > The philosophical problem I have with this suggestion is that I expect
> > that the large majority of users will be more happy with disabled TSO
> > if they use non standard qdiscs and defaults that do not fit
> > the majority use case are bad.
>
>
> If you mean the large majority of the large minority of users, who use
> non standard qdiscs - I agree - this is really the philosophical problem!
[....] Sorry if you had a point in this email I missed it.
-Andi
next prev parent reply other threads:[~2008-02-01 4:27 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 12:46 [PATCH] Disable TSO for non standard qdiscs Andi Kleen
2008-01-31 17:23 ` Stephen Hemminger
2008-01-31 18:33 ` Andi Kleen
2008-01-31 18:01 ` Patrick McHardy
2008-01-31 18:37 ` Andi Kleen
2008-01-31 18:08 ` Stephen Hemminger
2008-01-31 18:11 ` Patrick McHardy
2008-01-31 18:53 ` Andi Kleen
2008-01-31 18:21 ` Patrick McHardy
2008-01-31 19:01 ` Andi Kleen
2008-01-31 18:47 ` Waskiewicz Jr, Peter P
2008-01-31 19:34 ` Andi Kleen
2008-01-31 19:39 ` Waskiewicz Jr, Peter P
2008-01-31 23:10 ` Arnaldo Carvalho de Melo
2008-01-31 23:42 ` Waskiewicz Jr, Peter P
2008-02-01 4:26 ` Patrick McHardy
2008-02-01 4:35 ` Andi Kleen
2008-02-01 4:36 ` Andi Kleen
2008-01-31 20:33 ` Jarek Poplawski
2008-01-31 23:04 ` Jarek Poplawski
2008-02-01 7:42 ` Jarek Poplawski
2008-02-01 9:28 ` Waskiewicz Jr, Peter P
2008-02-01 21:47 ` Jarek Poplawski
2008-02-01 5:01 ` Andi Kleen [this message]
2008-02-01 6:35 ` Glen Turner
2008-02-01 6:46 ` Patrick McHardy
2008-02-01 7:46 ` Andi Kleen
2008-02-01 7:25 ` Patrick McHardy
2008-02-01 9:37 ` Waskiewicz Jr, Peter P
2008-02-01 9:56 ` Patrick McHardy
2008-02-01 12:06 ` jamal
2008-02-01 19:02 ` Waskiewicz Jr, Peter P
2008-02-01 22:56 ` Jarek Poplawski
2008-02-02 1:51 ` Waskiewicz Jr, Peter P
2008-02-02 5:20 ` Andi Kleen
2008-02-01 14:34 ` Andi Kleen
2008-02-01 17:24 ` Stephen Hemminger
2008-01-31 18:48 ` Patrick McHardy
2008-02-02 22:57 ` Herbert Xu
2008-02-03 9:35 ` Andi Kleen
2008-01-31 18:26 ` Rick Jones
2008-01-31 19:03 ` Andi Kleen
2008-01-31 18:35 ` Rick Jones
2008-01-31 19:25 ` Andi Kleen
2008-01-31 19:14 ` Rick Jones
2008-02-01 1:04 ` Andy Furniss
2008-02-01 4:31 ` Andi Kleen
2008-02-02 22:59 ` Herbert Xu
2008-02-01 21:58 ` Rick Jones
2008-02-02 4:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201050146.GD10720@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.