All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ursula Braun <braunu@de.ibm.com>
To: jgarzik@pobox.com, netdev@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Peter Tiedemann <ptiedem@de.ibm.com>
Subject: [patch 1/7] ctc / netiucv: consolidate fsm_action_nop
Date: Fri, 01 Feb 2008 15:51:29 +0100	[thread overview]
Message-ID: <20080201145256.683055000@linux.vnet.ibm.com> (raw)
In-Reply-To: 20080201145128.462823000@linux.vnet.ibm.com

[-- Attachment #1: fsm.diff --]
[-- Type: text/plain, Size: 2232 bytes --]

From: Peter Tiedemann <ptiedem@de.ibm.com>

move fsm_action_nop to fsm.h to avoid duplicate definitions in
both drivers ctc and netiucv.

Signed-off-by: Peter Tiedemann <ptiedem@de.ibm.com>
Signed-off-by: Ursula Braun <braunu@de.ibm.com>

---
 drivers/s390/net/ctcmain.c |    8 --------
 drivers/s390/net/fsm.h     |    8 ++++++++
 drivers/s390/net/netiucv.c |    8 +-------
 3 files changed, 9 insertions(+), 15 deletions(-)

Index: linux-2.6-uschi/drivers/s390/net/fsm.h
===================================================================
--- linux-2.6-uschi.orig/drivers/s390/net/fsm.h
+++ linux-2.6-uschi/drivers/s390/net/fsm.h
@@ -260,4 +260,12 @@ extern int fsm_addtimer(fsm_timer *timer
  */
 extern void fsm_modtimer(fsm_timer *timer, int millisec, int event, void *arg);
 
+/**
+ * NOP action for statemachines
+ */
+static inline void
+fsm_action_nop(fsm_instance *fi, int event, void *arg)
+{
+}
+
 #endif /* _FSM_H_ */
Index: linux-2.6-uschi/drivers/s390/net/netiucv.c
===================================================================
--- linux-2.6-uschi.orig/drivers/s390/net/netiucv.c
+++ linux-2.6-uschi/drivers/s390/net/netiucv.c
@@ -137,6 +137,7 @@ PRINT_##importance(header "%02x %02x %02
 #define PRINTK_HEADER " iucv: "       /* for debugging */
 
 static struct device_driver netiucv_driver = {
+	.owner = THIS_MODULE,
 	.name = "netiucv",
 	.bus  = &iucv_bus,
 };
@@ -571,13 +572,6 @@ static void netiucv_callback_connres(str
 	fsm_event(conn->fsm, CONN_EVENT_CONN_RES, conn);
 }
 
-/**
- * Dummy NOP action for all statemachines
- */
-static void fsm_action_nop(fsm_instance *fi, int event, void *arg)
-{
-}
-
 /*
  * Actions of the connection statemachine
  */
Index: linux-2.6-uschi/drivers/s390/net/ctcmain.c
===================================================================
--- linux-2.6-uschi.orig/drivers/s390/net/ctcmain.c
+++ linux-2.6-uschi/drivers/s390/net/ctcmain.c
@@ -644,14 +644,6 @@ ctc_checkalloc_buffer(struct channel *ch
 }
 
 /**
- * Dummy NOP action for statemachines
- */
-static void
-fsm_action_nop(fsm_instance * fi, int event, void *arg)
-{
-}
-
-/**
  * Actions for channel - statemachines.
  *****************************************************************************/
 

-- 

  reply	other threads:[~2008-02-01 14:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 14:51 [patch 0/7] s390: ctc patches for 2.6.25 Ursula Braun
2008-02-01 14:51 ` Ursula Braun [this message]
2008-02-01 14:51 ` [patch 2/7] drivers/s390/net: Kconfig brush up Ursula Braun
2008-02-01 14:51 ` [patch 3/7] ctcm: infrastructure for replaced ctc driver Ursula Braun
2008-02-01 14:51 ` [patch 4/7] ctcm: replaced ctc driver - part 1 Ursula Braun
2008-02-01 14:51 ` [patch 5/7] ctcm: replaced ctc driver - part 2 Ursula Braun
2008-02-01 14:51 ` [patch 6/7] ctcm: replaced ctc driver - part 3 Ursula Braun
2008-02-01 14:51 ` [patch 7/7] ctc: removal of the old ctc driver Ursula Braun
2008-02-01 18:30 ` [patch 0/7] s390: ctc patches for 2.6.25 Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201145256.683055000@linux.vnet.ibm.com \
    --to=braunu@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ptiedem@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.