From: Ingo Molnar <mingo@elte.hu>
To: Willy Tarreau <w@1wt.eu>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] X86: Fix trailing statements should be on next line
Date: Fri, 1 Feb 2008 17:21:39 +0100 [thread overview]
Message-ID: <20080201162139.GC15156@elte.hu> (raw)
In-Reply-To: <20080128230746.GL8953@1wt.eu>
* Willy Tarreau <w@1wt.eu> wrote:
> Hi Paolo,
>
> On Tue, Jan 29, 2008 at 12:07:44AM +0100, Paolo Ciarrocchi wrote:
> > Fix trailing statements should be on next line
>
> > -if ( partial_status & SW_C3 ) printk("SW: condition bit 3\n");
> > -if ( partial_status & SW_C2 ) printk("SW: condition bit 2\n");
> > -if ( partial_status & SW_C1 ) printk("SW: condition bit 1\n");
> > -if ( partial_status & SW_C0 ) printk("SW: condition bit 0\n");
> > -if ( partial_status & SW_Summary ) printk("SW: exception summary\n");
> > -if ( partial_status & SW_Stack_Fault ) printk("SW: stack fault\n");
> > -if ( partial_status & SW_Precision ) printk("SW: loss of precision\n");
> > -if ( partial_status & SW_Underflow ) printk("SW: underflow\n");
> > -if ( partial_status & SW_Overflow ) printk("SW: overflow\n");
> > -if ( partial_status & SW_Zero_Div ) printk("SW: divide by zero\n");
> > -if ( partial_status & SW_Denorm_Op ) printk("SW: denormalized operand\n");
> > -if ( partial_status & SW_Invalid ) printk("SW: invalid operation\n");
>
> > +if ( partial_status & SW_Backward )
> > +printk("SW: backward compatibility\n");
> > +if ( partial_status & SW_C3 )
> > +printk("SW: condition bit 3\n");
> > +if ( partial_status & SW_C2 )
> > +printk("SW: condition bit 2\n");
> > +if ( partial_status & SW_C1 )
> > +printk("SW: condition bit 1\n");
> > +if ( partial_status & SW_C0 )
> > +printk("SW: condition bit 0\n");
> > +if ( partial_status & SW_Summary )
> > +printk("SW: exception summary\n");
> > +if ( partial_status & SW_Stack_Fault )
> > +printk("SW: stack fault\n");
> > +if ( partial_status & SW_Precision )
> > +printk("SW: loss of precision\n");
> > +if ( partial_status & SW_Underflow )
> > +printk("SW: underflow\n");
> > +if ( partial_status & SW_Overflow )
> > +printk("SW: overflow\n");
> > +if ( partial_status & SW_Zero_Div )
> > +printk("SW: divide by zero\n");
> > +if ( partial_status & SW_Denorm_Op )
> > +printk("SW: denormalized operand\n");
> > +if ( partial_status & SW_Invalid )
> > +printk("SW: invalid operation\n");
> > #endif /* DEBUGGING */
>
> Well, IMHO, the code was more readable and checkable in the initial
> version. I think this is one example of exceptions where code
> appearance is more important than style correctness.
definitely so. The rule of thumb is: if in doubt, use your human taste.
Does it 'look' better? If not, dont do the change.
Ingo
prev parent reply other threads:[~2008-02-01 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 23:07 [PATCH 3/7] X86: Fix trailing statements should be on next line Paolo Ciarrocchi
2008-01-28 23:07 ` Willy Tarreau
2008-01-29 12:43 ` Stefan Richter
2008-02-01 16:21 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201162139.GC15156@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.ciarrocchi@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.