From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759196AbYBARSt (ORCPT ); Fri, 1 Feb 2008 12:18:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756000AbYBARSm (ORCPT ); Fri, 1 Feb 2008 12:18:42 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:48729 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083AbYBARSm (ORCPT ); Fri, 1 Feb 2008 12:18:42 -0500 Date: Fri, 1 Feb 2008 18:18:26 +0100 From: Ingo Molnar To: Cyrill Gorcunov Cc: Thomas Gleixner , Andi Kleen , "H. Peter Anvin" , LKML Subject: Re: [PATCH] x86: cleanup - eliminate numbers in LDT allocation code Message-ID: <20080201171826.GA13738@elte.hu> References: <20080201171422.GA6730@cvg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080201171422.GA6730@cvg> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Cyrill Gorcunov wrote: > This patch eliminates numbers in LDT allocation code trying to make it > clear to understand from where these numbers are go thanks, applied. > I hope nobody shoot me ;) nope, magic constants are bad in general. Ingo