From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JL23g-0004jb-BY for mharc-grub-devel@gnu.org; Fri, 01 Feb 2008 15:00:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JL23f-0004i2-4g for grub-devel@gnu.org; Fri, 01 Feb 2008 15:00:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JL23d-0004gP-BS for grub-devel@gnu.org; Fri, 01 Feb 2008 15:00:18 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JL23c-0004gA-Uk for grub-devel@gnu.org; Fri, 01 Feb 2008 15:00:17 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JL23c-0006Sr-IB for grub-devel@gnu.org; Fri, 01 Feb 2008 15:00:16 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JL23b-0000gv-E6 for grub-devel@gnu.org; Fri, 01 Feb 2008 21:00:15 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JL222-0007UI-UJ for grub-devel@gnu.org; Fri, 01 Feb 2008 20:58:38 +0100 Date: Fri, 1 Feb 2008 20:58:38 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080201195838.GA28745@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: read_config_file() is missleading X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2008 20:00:19 -0000 The following function name: normal/main.c:read_config_file (const char *config, int nested) is missleading. It does actually execute the config file, not just read it. Does it seem fine to rename it? How about `process_config_file' ? Or maybe I am missing something. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)