From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: [PATCH] don't display menu when there's nothing in it
Date: Fri, 1 Feb 2008 21:02:30 +0100 [thread overview]
Message-ID: <20080201200230.GA29932@thorin> (raw)
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
normal.mod seems to insist in displaying a menu even if grub.cfg didn't
define any menu entries. This seems to be due to a bogus check (for
menu instead of menu->size).
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
[-- Attachment #2: non-menu.diff --]
[-- Type: text/x-diff, Size: 529 bytes --]
* normal/main.c (grub_normal_execute): Check for `menu->size' rather
than `menu' when determining whether menu has to be displayed.
diff -x CVS -x '*~' -x '*.mk' -urp ../grub2/normal/main.c ./normal/main.c
--- ../grub2/normal/main.c 2008-01-15 16:32:17.000000000 +0100
+++ ./normal/main.c 2008-02-01 20:58:56.000000000 +0100
@@ -474,7 +474,7 @@ grub_normal_execute (const char *config,
grub_errno = GRUB_ERR_NONE;
}
- if (menu)
+ if (menu->size)
{
grub_menu_run (menu, nested);
if (nested)
next reply other threads:[~2008-02-01 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 20:02 Robert Millan [this message]
2008-02-02 12:20 ` [PATCH] don't display menu when there's nothing in it Yoshinori K. Okuji
2008-02-02 16:47 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201200230.GA29932@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.