From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JL3ce-0000b2-0K for mharc-grub-devel@gnu.org; Fri, 01 Feb 2008 16:40:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JL3cc-0000Wm-4M for grub-devel@gnu.org; Fri, 01 Feb 2008 16:40:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JL3ca-0000SX-Ky for grub-devel@gnu.org; Fri, 01 Feb 2008 16:40:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JL3ca-0000SK-Gr for grub-devel@gnu.org; Fri, 01 Feb 2008 16:40:28 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JL3ca-0006dO-E8 for grub-devel@gnu.org; Fri, 01 Feb 2008 16:40:28 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JL3cW-0000sM-Ox for grub-devel@gnu.org; Fri, 01 Feb 2008 22:40:26 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JL3al-0001Ix-Lf for grub-devel@gnu.org; Fri, 01 Feb 2008 22:38:35 +0100 Date: Fri, 1 Feb 2008 22:38:35 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080201213835.GA4855@thorin> References: <20080129134707.GF27435@thorin> <20080130003750.GB1341@kirkkit.kollasch.net> <20080130132314.GA15277@thorin> <1201701103.17791.9.camel@k9.localnet> <20080130140017.GA16576@thorin> <1201720010.27623.26.camel@k9.localnet> <20080130215559.GC1341@kirkkit.kollasch.net> <20080131110328.GA12043@thorin> <1201900266.744.3.camel@k9.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1201900266.744.3.camel@k9.localnet> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Compiling grub2 on *BSD? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2008 21:40:30 -0000 On Fri, Feb 01, 2008 at 01:11:06PM -0800, walt wrote: > > ... if we remove -lgcc, what happens if it becomes necessary for other versions > > of GCC? Or does gcc already add libgcc per demand? > > I got grub2 compiled on NetBSD using the fake in those pkgsrc patches. > I regenerated the patches below against grub2 cvs. They are the same > ideas you suggested earlier, I just didn't use them all at the same > time: Nice. Some comments: > --- include/grub/mm.h 21 Jul 2007 23:32:22 -0000 1.8 > +++ include/grub/mm.h 1 Feb 2008 21:04:27 -0000 > @@ -33,6 +33,7 @@ > void EXPORT_FUNC(grub_free) (void *ptr); > void *EXPORT_FUNC(grub_realloc) (void *ptr, grub_size_t size); > void *EXPORT_FUNC(grub_memalign) (grub_size_t align, grub_size_t size); > +void EXPORT_FUNC(__enable_execute_stack) (void); > > /* For debugging. */ > #if defined(MM_DEBUG) && !defined(GRUB_UTIL) > Index: kern/mm.c > =================================================================== > RCS file: /sources/grub/grub2/kern/mm.c,v > retrieving revision 1.19 > diff -u -r1.19 mm.c > --- kern/mm.c 23 Jan 2008 14:57:40 -0000 1.19 > +++ kern/mm.c 1 Feb 2008 21:04:28 -0000 > @@ -66,6 +66,9 @@ > #include > #include > > +void __enable_execute_stack(void); Why this declaration; doesn't it duplicate the one in mm.h? > +void __enable_execute_stack(void) {} We need a comment explaining why we have this "weird" function in GRUB. Also, please follow grub code style: void foo (void) { } And, could you provide a ChangeLog entry with your patch? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)