From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JL4hY-0006hl-BW
	for mharc-grub-devel@gnu.org; Fri, 01 Feb 2008 17:49:40 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JL4hW-0006g6-Gd
	for grub-devel@gnu.org; Fri, 01 Feb 2008 17:49:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JL4hU-0006fW-VY
	for grub-devel@gnu.org; Fri, 01 Feb 2008 17:49:38 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JL4hU-0006fM-Nw
	for grub-devel@gnu.org; Fri, 01 Feb 2008 17:49:36 -0500
Received: from aybabtu.com ([69.60.117.155])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1JL4hU-00083Z-9I
	for grub-devel@gnu.org; Fri, 01 Feb 2008 17:49:36 -0500
Received: from [192.168.10.6] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <rmh@aybabtu.com>) id 1JL4hS-0000zh-LA
	for grub-devel@gnu.org; Fri, 01 Feb 2008 23:49:35 +0100
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1JL4fw-00039F-CM
	for grub-devel@gnu.org; Fri, 01 Feb 2008 23:48:00 +0100
Date: Fri, 1 Feb 2008 23:48:00 +0100
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Message-ID: <20080201224800.GA12043@thorin>
References: <20080201224550.GA11984@thorin>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080201224550.GA11984@thorin>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] read command
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2008 22:49:38 -0000

On Fri, Feb 01, 2008 at 11:45:50PM +0100, Robert Millan wrote:
> +static void *
> +grub_xrealloc (void *ptr, grub_size_t size)
> +{
> +  void *value = grub_realloc (ptr, size);
> +  if (value == 0)
> +    grub_fatal ("Virtual memory exhausted");
> +  return value;
> +}
> +
> +static char *
> +grub_getline (void)
> +{
> +  int i;
> +  char *line;
> +
> +  i = 0;
> +  line = grub_malloc (1 + i + sizeof('\0'));
> +
> +  while ((line[i - 1] != '\n') && (line[i - 1] != '\r'))
> +    {
> +      line[i] = grub_getkey ();
> +      if (grub_isprint (line[i]))
> +	grub_putchar (line[i]);
> +      i++;
> +      line = grub_xrealloc (line, 1 + i + sizeof('\0'));
> +    }
> +  line[i] = '\0';
> +
> +  return line;
> +}

Does it make sense to move any of these two to kernel?  Or to normal.mod ?  Or
maybe just to un-static-ize them and leave them here?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)