From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: read_config_file() is missleading
Date: Sat, 2 Feb 2008 13:14:45 +0100 [thread overview]
Message-ID: <200802021314.45401.okuji@enbug.org> (raw)
In-Reply-To: <20080201195838.GA28745@thorin>
On Friday 01 February 2008 20:58, Robert Millan wrote:
> The following function name:
>
> normal/main.c:read_config_file (const char *config, int nested)
>
> is missleading. It does actually execute the config file, not just
> read it. Does it seem fine to rename it?
>
> How about `process_config_file' ?
>
> Or maybe I am missing something.
I think the initial idea was that read_config_file would only read a file,
then a menu would be executed by another function. But it is not for some
reason. I forget why. Maybe it didn't make sense to separate the
functionality into two functions. I am not sure.
If you can think of any reason that we should separate the functionality, you
can make process_config or something like that. Otherwise, it is fine for me
to rename the function.
Okuji
next prev parent reply other threads:[~2008-02-02 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 19:58 read_config_file() is missleading Robert Millan
2008-02-02 12:14 ` Yoshinori K. Okuji [this message]
2008-02-02 12:20 ` Yoshinori K. Okuji
2008-02-02 16:37 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802021314.45401.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.