From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLHLu-0003oL-AH for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:10 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLHLs-0003o8-Ny for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLHLr-0003nw-DW for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:07 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLHLr-0003nt-7H for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:07 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JLHLr-0002iJ-4K for grub-devel@gnu.org; Sat, 02 Feb 2008 07:20:07 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id E38A33EB26 for ; Sat, 2 Feb 2008 13:26:49 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 2 Feb 2008 13:20:04 +0100 User-Agent: KMail/1.9.4 References: <20080201195838.GA28745@thorin> <200802021314.45401.okuji@enbug.org> In-Reply-To: <200802021314.45401.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802021320.04918.okuji@enbug.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: read_config_file() is missleading X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 12:20:08 -0000 On Saturday 02 February 2008 13:14, Yoshinori K. Okuji wrote: > On Friday 01 February 2008 20:58, Robert Millan wrote: > > The following function name: > > > > normal/main.c:read_config_file (const char *config, int nested) > > > > is missleading. It does actually execute the config file, not just > > read it. Does it seem fine to rename it? > > > > How about `process_config_file' ? > > > > Or maybe I am missing something. > > I think the initial idea was that read_config_file would only read a file, > then a menu would be executed by another function. But it is not for some > reason. I forget why. Maybe it didn't make sense to separate the > functionality into two functions. I am not sure. > > If you can think of any reason that we should separate the functionality, > you can make process_config or something like that. Otherwise, it is fine > for me to rename the function. I was mistaken. It really depends on the meaning of "execute". For me, executing a menu means analyzing the menu structure, displaying it, controlling user inputs, and so on. read_menu_config does not execute a menu in this sense. But, of course, it executes commands in a config file. Okuji