From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLLLz-0000U9-Kw for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 11:36:31 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLLLy-0000SI-4i for grub-devel@gnu.org; Sat, 02 Feb 2008 11:36:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLLLx-0000RP-5Q for grub-devel@gnu.org; Sat, 02 Feb 2008 11:36:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLLLw-0000RD-UM for grub-devel@gnu.org; Sat, 02 Feb 2008 11:36:28 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JLLLw-0002uE-Kt for grub-devel@gnu.org; Sat, 02 Feb 2008 11:36:28 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JLLLj-0002Qr-0R for grub-devel@gnu.org; Sat, 02 Feb 2008 17:36:17 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JLLJR-0006St-7U for grub-devel@gnu.org; Sat, 02 Feb 2008 17:33:53 +0100 Date: Sat, 2 Feb 2008 17:33:53 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080202163353.GA24700@thorin> References: <20080131110906.GC12043@thorin> <200801311236.44594.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] eltorito cdrom boot X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 16:36:30 -0000 On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote: > > any objection for this patch ? i would like to commit it soon. Looks fine to me. Just a minor comment: > +#define GRUB_BIOSDISK_MACHINE_CDROM_START 0xe0 > +#define GRUB_BIOSDISK_MACHINE_CDROM_END 0xf0 could you make this tab-indented? Also, I notice that GRUB_BIOSDISK_MACHINE_CDROM_END is not used. Did you plan to add a sanity check in init.c using this macro ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)