From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLLV9-0005qs-Th for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 11:45:59 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLLV7-0005pn-Np for grub-devel@gnu.org; Sat, 02 Feb 2008 11:45:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLLV6-0005pW-ES for grub-devel@gnu.org; Sat, 02 Feb 2008 11:45:57 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLLV6-0005pS-Bm for grub-devel@gnu.org; Sat, 02 Feb 2008 11:45:56 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JLLV5-0004Ml-Um for grub-devel@gnu.org; Sat, 02 Feb 2008 11:45:56 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JLLUp-0002RY-IY for grub-devel@gnu.org; Sat, 02 Feb 2008 17:45:39 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JLLSg-0006ZU-6V for grub-devel@gnu.org; Sat, 02 Feb 2008 17:43:26 +0100 Date: Sat, 2 Feb 2008 17:43:26 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080202164326.GD24700@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Move os dependent code to a separate file ? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 16:45:58 -0000 On Sat, Feb 02, 2008 at 10:29:20PM +0800, Bean wrote: > Hi, > > i can see that there are linux specific code in util/biosdisk.c, > perhaps we should move them to a separate file such as util/osdep.c ? In general I don't like very much to split unportable code in separate files because it's easy to lose context of what it is doing. But some Linux-specific code in that file is obsolete, IIRC, inherited from GRUB Legacy just to support ancient libcs. Maybe part of it needs to be considered for removal. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)