From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLLZR-0003RK-MA for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 11:50:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLLZP-0003PP-OV for grub-devel@gnu.org; Sat, 02 Feb 2008 11:50:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLLZO-0003NP-2A for grub-devel@gnu.org; Sat, 02 Feb 2008 11:50:23 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLLZN-0003NH-QG for grub-devel@gnu.org; Sat, 02 Feb 2008 11:50:21 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JLLZN-0005AK-DM for grub-devel@gnu.org; Sat, 02 Feb 2008 11:50:21 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JLLZ9-0002Rt-QB for grub-devel@gnu.org; Sat, 02 Feb 2008 17:50:08 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JLLWx-0006cc-Qd for grub-devel@gnu.org; Sat, 02 Feb 2008 17:47:51 +0100 Date: Sat, 2 Feb 2008 17:47:51 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080202164751.GA25374@thorin> References: <20080201200230.GA29932@thorin> <200802021320.49710.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200802021320.49710.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] don't display menu when there's nothing in it X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 16:50:23 -0000 On Sat, Feb 02, 2008 at 01:20:49PM +0100, Yoshinori K. Okuji wrote: > On Friday 01 February 2008 21:02, Robert Millan wrote: > > normal.mod seems to insist in displaying a menu even if grub.cfg didn't > > define any menu entries. This seems to be due to a bogus check (for > > menu instead of menu->size). > > It is not completely bogus, since MENU can be NULL. Probably what you want is: > > if (menu && menu->size) Good catch. Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)