From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] eltorito cdrom boot
Date: Sat, 2 Feb 2008 18:24:34 +0100 [thread overview]
Message-ID: <20080202172434.GA13635@thorin> (raw)
In-Reply-To: <ca0f59980802020916m33f11bd2qd4d3f97b5fa014e9@mail.gmail.com>
On Sun, Feb 03, 2008 at 01:16:50AM +0800, Bean wrote:
> On Feb 3, 2008 12:33 AM, Robert Millan <rmh@aybabtu.com> wrote:
> > On Sat, Feb 02, 2008 at 10:19:55PM +0800, Bean wrote:
> > >
> > > any objection for this patch ? i would like to commit it soon.
> >
> > Looks fine to me. Just a minor comment:
> >
> > > +#define GRUB_BIOSDISK_MACHINE_CDROM_START 0xe0
> > > +#define GRUB_BIOSDISK_MACHINE_CDROM_END 0xf0
> >
> > could you make this tab-indented?
>
> no problem.
>
> >
> > Also, I notice that GRUB_BIOSDISK_MACHINE_CDROM_END is not used. Did you plan
> > to add a sanity check in init.c using this macro ?
>
> it's used in GRUB_MOD_INIT(biosdisk) as the end drive letter to scan for cds.
Ah, sorry I got confused.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-02-02 17:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 19:22 [PATCH] eltorito cdrom boot Bean
2008-01-29 20:33 ` Robert Millan
2008-01-29 20:58 ` Marco Gerards
2008-01-30 15:13 ` Bean
2008-01-31 8:38 ` Bean
2008-01-31 11:09 ` Robert Millan
2008-01-31 11:36 ` Yoshinori K. Okuji
2008-01-31 12:43 ` Bean
2008-02-02 14:19 ` Bean
2008-02-02 16:33 ` Robert Millan
2008-02-02 17:16 ` Bean
2008-02-02 17:24 ` Robert Millan [this message]
2008-02-03 8:27 ` Bean
2008-01-31 12:47 ` Robert Millan
2008-01-31 13:04 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202172434.GA13635@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.