From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] read command
Date: Sat, 2 Feb 2008 19:48:57 +0100 [thread overview]
Message-ID: <200802021948.57501.okuji@enbug.org> (raw)
In-Reply-To: <20080202170549.GB25374@thorin>
On Saturday 02 February 2008 18:05, Robert Millan wrote:
> On Sat, Feb 02, 2008 at 01:38:28PM +0100, Yoshinori K. Okuji wrote:
> > > Does it make sense to move any of these two to kernel? Or to
> > > normal.mod ? Or maybe just to un-static-ize them and leave them here?
> >
> > What would be other use cases?
>
> No idea. I suggest we just leave grub_getline here and if later we find
> it's needed we can move it to normal or kernel.
OK.
> Ok, here's a new patch, with grub_getline returning NULL and the caller
> handling "out of mem" error.
>
> Also fixed a memleak.
You don't have to set grub_errno explicitly, because grub_realloc should do
it.
And, you didn't check the return value from grub_malloc.
Okuji
next prev parent reply other threads:[~2008-02-02 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 22:45 [PATCH] read command Robert Millan
2008-02-01 22:48 ` Robert Millan
2008-02-02 12:38 ` Yoshinori K. Okuji
2008-02-02 17:05 ` Robert Millan
2008-02-02 18:48 ` Yoshinori K. Okuji [this message]
2008-02-02 20:34 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802021948.57501.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.