From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLP6G-0006pB-5M for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 15:36:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLP6E-0006p4-MI for grub-devel@gnu.org; Sat, 02 Feb 2008 15:36:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLP69-0006oV-6E for grub-devel@gnu.org; Sat, 02 Feb 2008 15:36:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLP68-0006oQ-Vy for grub-devel@gnu.org; Sat, 02 Feb 2008 15:36:25 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JLP68-0001s8-Ny for grub-devel@gnu.org; Sat, 02 Feb 2008 15:36:24 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JLP5t-0002y1-N7 for grub-devel@gnu.org; Sat, 02 Feb 2008 21:36:10 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JLP3r-0006iC-5q for grub-devel@gnu.org; Sat, 02 Feb 2008 21:34:03 +0100 Date: Sat, 2 Feb 2008 21:34:03 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080202203403.GA18535@thorin> References: <20080201224550.GA11984@thorin> <200802021338.28362.okuji@enbug.org> <20080202170549.GB25374@thorin> <200802021948.57501.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200802021948.57501.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] read command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 20:36:30 -0000 On Sat, Feb 02, 2008 at 07:48:57PM +0100, Yoshinori K. Okuji wrote: > > Ok, here's a new patch, with grub_getline returning NULL and the caller > > handling "out of mem" error. > > > > Also fixed a memleak. > > You don't have to set grub_errno explicitly, because grub_realloc should do > it. > > And, you didn't check the return value from grub_malloc. Fixed and committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)