From: Ondrej Zary <linux@rainbow-software.org>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: netdev@vger.kernel.org,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
"Jeff Garzik" <jeff@garzik.org>
Subject: Re: [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2
Date: Sat, 2 Feb 2008 22:28:57 +0100 [thread overview]
Message-ID: <200802022228.59527.linux@rainbow-software.org> (raw)
In-Reply-To: <84144f020802021307ja672fdfl29e54483e9f900d@mail.gmail.com>
On Saturday 02 February 2008 22:07:20 Pekka Enberg wrote:
> Hi,
>
> On Feb 2, 2008 8:25 PM, Ondrej Zary <linux@rainbow-software.org> wrote:
> > +//static __be16 el3_phys_addr[EL3_MAX_CARDS][3];
>
> [snip]
>
> > +//#if defined(CONFIG_MCA) || defined(CONFIG_EISA)
>
> [snip]
>
> > +// while (el3_probe(el3_cards) == 0) {
> > +// if (irq[el3_cards] > 1)
> > +// el3_root_dev->irq = irq[el3_cards];
> > +// if (xcvr[el3_cards] >= 0)
> > +// el3_root_dev->if_port = xcvr[el3_cards];
> > +// el3_cards++;
> > +// }
>
> You might want to consider dropping these hunks...
Yes, they're going away. The last one is there just as a reminder that the irq
and xcvr parameters should be used in the ISA code.
--
Ondrej Zary
prev parent reply other threads:[~2008-02-02 21:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 19:12 [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver Ondrej Zary
2008-02-02 18:25 ` [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2 Ondrej Zary
2008-02-02 20:50 ` Jeff Garzik
2008-02-02 21:08 ` Ondrej Zary
2008-02-04 23:02 ` [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v3 Ondrej Zary
2008-02-06 18:09 ` [PATCH] [resend] " Ondrej Zary
2008-02-07 11:51 ` Marc Zyngier
2008-02-07 17:31 ` [PATCH] 3c509: convert to isa_driver and pnp_driver v4 Ondrej Zary
2008-02-09 21:33 ` [PATCH] [resend] " Ondrej Zary
2008-02-09 21:48 ` Stephen Hemminger
2008-02-10 0:10 ` Ondrej Zary
2008-02-10 5:18 ` Christoph Hellwig
2008-02-10 21:03 ` [PATCH] 3c509: convert to isa_driver and pnp_driver v5 Ondrej Zary
2008-02-13 21:28 ` [PATCH] [resend] " Ondrej Zary
2008-02-17 11:02 ` Ondrej Zary
2008-03-04 4:25 ` Andrew Morton
2008-02-02 21:07 ` [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2 Pekka Enberg
2008-02-02 21:28 ` Ondrej Zary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802022228.59527.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.