From: Al Viro <viro@ZenIV.linux.org.uk>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: xfrm_input() and ->seq oddities
Date: Sun, 3 Feb 2008 00:37:19 +0000 [thread overview]
Message-ID: <20080203003718.GQ27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080203002019.GA32295@gondor.apana.org.au>
On Sun, Feb 03, 2008 at 11:20:19AM +1100, Herbert Xu wrote:
> Al Viro spotted a bogus use of u64 on the input sequence number which
> is big-endian. This patch fixes it by giving the input sequence number
> its own member in the xfrm_skb_cb structure.
This is still very odd... Where do you initialize ->seq.input? What
guarantees that async call of xfrm_input() will be always preceded by
at least one non-async one?
next prev parent reply other threads:[~2008-02-03 0:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 21:16 [2.6 patch] xfrm4_beet_input(): fix an if() Adrian Bunk
2008-02-02 22:22 ` Herbert Xu
[not found] ` <20080202235827.GP27894@ZenIV.linux.org.uk>
2008-02-03 0:20 ` xfrm_input() and ->seq oddities Herbert Xu
2008-02-03 0:37 ` Al Viro [this message]
2008-02-03 3:05 ` Herbert Xu
2008-02-03 11:04 ` Al Viro
2008-02-03 22:00 ` Herbert Xu
2008-02-13 6:54 ` David Miller
2008-02-13 6:54 ` David Miller
2008-02-05 10:51 ` [2.6 patch] xfrm4_beet_input(): fix an if() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203003718.GQ27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.