All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	Hannes Reinecke <hare@suse.de>,
	James Bottomley <James.Bottomley@steeleye.com>,
	Christoph Hellwig <hch@lst.de>
Subject: [patch] scsi: fix spurious build failures in aic7xxx
Date: Sun, 3 Feb 2008 05:54:41 +0100	[thread overview]
Message-ID: <20080203045441.GA12128@elte.hu> (raw)
In-Reply-To: <20080202171020.GB12748@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> > I could not reproduce the bug myself but I think I spotted it. We 
> > had a missing dependency to the _reg.h file. Try following patch and 
> > let me now if it continue to break.
> 
> thanks! I threw this into the test setup and will know by tomorrow 
> whether there's any breakage.

good news: hundreds of successful kernel builds and no failures 
overnight. I've Cc:-ed the aic7xxx people.

	Ingo

------------------->
Subject: scsi: fix spurious build failures in aic7xxx
From: Sam Ravnborg <sam@ravnborg.org>

We had a missing dependency to the _reg.h file.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/scsi/aic7xxx/Makefile |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Index: linux/drivers/scsi/aic7xxx/Makefile
===================================================================
--- linux.orig/drivers/scsi/aic7xxx/Makefile
+++ linux/drivers/scsi/aic7xxx/Makefile
@@ -44,13 +44,8 @@ clean-files += aic79xx_seq.h aic79xx_reg
 
 # Dependencies for generated files need to be listed explicitly
 
-$(obj)/aic7xxx_core.o: $(obj)/aic7xxx_seq.h
-$(obj)/aic7xxx_core.o: $(obj)/aic7xxx_reg.h
-$(obj)/aic79xx_core.o: $(obj)/aic79xx_seq.h
-$(obj)/aic79xx_core.o: $(obj)/aic79xx_reg.h
-
-$(addprefix $(obj)/,$(aic7xxx-y)): $(obj)/aic7xxx_seq.h
-$(addprefix $(obj)/,$(aic79xx-y)): $(obj)/aic79xx_seq.h
+$(addprefix $(obj)/,$(aic7xxx-y:.o=.c)): $(obj)/aic7xxx_seq.h $(obj)/aic7xxx_reg.h
+$(addprefix $(obj)/,$(aic79xx-y:.o=.c)): $(obj)/aic79xx_seq.h $(obj)/aic79xx_reg.h
 
 aic7xxx-gen-$(CONFIG_AIC7XXX_BUILD_FIRMWARE)	:= $(obj)/aic7xxx_reg.h
 aic7xxx-gen-$(CONFIG_AIC7XXX_REG_PRETTY_PRINT)	+= $(obj)/aic7xxx_reg_print.c

  reply	other threads:[~2008-02-03  4:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 22:50 [scsi bug] spurious build failures in aic7xxx Ingo Molnar
2008-02-01 23:02 ` Sam Ravnborg
2008-02-02 13:59 ` Sam Ravnborg
2008-02-02 14:03   ` Ingo Molnar
2008-02-02 14:06     ` Ingo Molnar
2008-02-02 14:18       ` Ingo Molnar
2008-02-02 16:26         ` Sam Ravnborg
2008-02-02 17:10           ` Ingo Molnar
2008-02-03  4:54             ` Ingo Molnar [this message]
2008-02-03  7:41               ` [patch] scsi: fix " Sam Ravnborg
2008-02-03 19:23                 ` James Bottomley
2008-02-03 20:05                   ` Sam Ravnborg
2008-02-03 20:15                     ` James Bottomley
2008-02-03 20:38                       ` Sam Ravnborg
2008-02-03 20:48                         ` James Bottomley
2008-02-04  7:33                 ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080203045441.GA12128@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@steeleye.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.