From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLeOM-0003Zg-MB for mharc-grub-devel@gnu.org; Sun, 03 Feb 2008 07:56:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLeOL-0003Z7-1S for grub-devel@gnu.org; Sun, 03 Feb 2008 07:56:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLeOJ-0003YJ-Cw for grub-devel@gnu.org; Sun, 03 Feb 2008 07:56:12 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLeOJ-0003YE-9C for grub-devel@gnu.org; Sun, 03 Feb 2008 07:56:11 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JLeOI-00004v-TO for grub-devel@gnu.org; Sun, 03 Feb 2008 07:56:11 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JLeMb-0001sL-Rx for grub-devel@gnu.org; Sun, 03 Feb 2008 13:54:26 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JLcV8-0005Cv-PJ for grub-devel@gnu.org; Sun, 03 Feb 2008 11:55:06 +0100 Date: Sun, 3 Feb 2008 11:55:06 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080203105506.GA19947@thorin> References: <20080202204400.GA346@thorin> <87r6fvcbw2.fsf@xs4all.nl> <20080202210714.GA7593@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub.cfg parser still doesn't abort on error X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2008 12:56:13 -0000 On Sun, Feb 03, 2008 at 11:05:26AM +0800, Bean wrote: > > > > Try the following grub.cfg: > > > > > > > > cat (memdisk)/non-existant-file > > > > echo this point should never be reached > > > > read > > > > > > > > You'll see that the echo is reached, even if cat returned an error. > > > > > > > > This becomes much worse when found in situations like: > > > > > > > > font (xxx)/some-file.pff > > > > terminal gfxterm > > > > > > > > and the font wasn't loaded. > > > > > > Urgh! Bean committed a patch that zero'ed the error. Perhaps it was > > > wrong? ;-) > > > > > > Can you try reverting it? :-) > > > > Actually, it was wrong before that. > > i think you can use the if statement to test command result. You mean it is intentional? I think it's a bad plan to assume user will check for error status of each command, specially in situations like font/gfxterm. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)