From: Simon Hausmann <simon@lst.de>
To: Tommy Thorn <tt1729@yahoo.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] git-p4: Fix an obvious typo
Date: Sun, 3 Feb 2008 19:36:02 +0100 [thread overview]
Message-ID: <200802031936.02828.simon@lst.de> (raw)
In-Reply-To: <182304.89601.qm@web39507.mail.mud.yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
On Saturday 02 February 2008 09:11:44 Tommy Thorn wrote:
> The regexp "$," can't match anything. Clearly not intended.
>
> This was introduced in ce6f33c8 which is quite a while ago.
>
> Signed-off-by: Tommy Thorn <tommy-git@thorn.ws>
Acked-by: Simon Hausmann <simon@lst.de>
Simon
> ---
> contrib/fast-import/git-p4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index c80a6da..553e237 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1670,7 +1670,7 @@ class P4Clone(P4Sync):
> depotPath = args[0]
> depotDir = re.sub("(@[^@]*)$", "", depotPath)
> depotDir = re.sub("(#[^#]*)$", "", depotDir)
> - depotDir = re.sub(r"\.\.\.$,", "", depotDir)
> + depotDir = re.sub(r"\.\.\.$", "", depotDir)
> depotDir = re.sub(r"/$", "", depotDir)
> return os.path.split(depotDir)[1]
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-02-03 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 8:11 [PATCH] git-p4: Fix an obvious typo Tommy Thorn
2008-02-03 18:36 ` Simon Hausmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802031936.02828.simon@lst.de \
--to=simon@lst.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=tt1729@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.