From: Ingo Molnar <mingo@elte.hu>
To: Lukas Hejtmanek <xhejtman@ics.muni.cz>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: 2.6.24-git4+ regression
Date: Mon, 4 Feb 2008 13:01:32 +0100 [thread overview]
Message-ID: <20080204120131.GA20962@elte.hu> (raw)
In-Reply-To: <20080204111747.GB4450@ics.muni.cz>
* Lukas Hejtmanek <xhejtman@ics.muni.cz> wrote:
> but in such a case, kernel 2.6.24-git13 does oops at startup in
> sched_slice.
could you tell me more about this oops? You booted unmodified, latest
-git and it oopsed in sched_slice()? The patch below should work around
any oopses in sched_slice(). [but this is really a 'must not happen'
scenario - so a just-for-testing patch]
Ingo
Index: linux-x86.q/kernel/sched_fair.c
===================================================================
--- linux-x86.q.orig/kernel/sched_fair.c
+++ linux-x86.q/kernel/sched_fair.c
@@ -268,7 +268,8 @@ static u64 sched_slice(struct cfs_rq *cf
u64 slice = __sched_period(cfs_rq->nr_running);
slice *= se->load.weight;
- do_div(slice, cfs_rq->load.weight);
+ if (cfs_rq->load.weight)
+ do_div(slice, cfs_rq->load.weight);
return slice;
}
next prev parent reply other threads:[~2008-02-04 12:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 13:56 2.6.24-git4+ regression Lukas Hejtmanek
2008-01-31 10:29 ` Ingo Molnar
2008-01-31 10:55 ` Lukas Hejtmanek
2008-02-04 11:17 ` Lukas Hejtmanek
2008-02-04 11:36 ` Peter Zijlstra
2008-02-04 14:36 ` Lukas Hejtmanek
2008-02-04 14:45 ` Peter Zijlstra
2008-02-04 17:00 ` Lukas Hejtmanek
2008-02-04 12:01 ` Ingo Molnar [this message]
2008-02-04 12:29 ` Lukas Hejtmanek
2008-02-04 13:04 ` Ingo Molnar
2008-02-04 13:49 ` Lukas Hejtmanek
2008-02-14 16:55 ` Srivatsa Vaddagiri
2008-02-17 20:26 ` Lukas Hejtmanek
2008-02-18 4:28 ` Ingo Molnar
2008-02-18 7:38 ` Mike Galbraith
2008-02-18 8:20 ` Srivatsa Vaddagiri
2008-02-18 8:36 ` Mike Galbraith
[not found] ` <1203325554.4889.2.camel@homer.simson.net>
[not found] ` <1203345102.5984.1.camel@homer.simson.net>
2008-02-19 8:15 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080204120131.GA20962@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xhejtman@ics.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.