From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JM2tD-0004QM-VW for mharc-grub-devel@gnu.org; Mon, 04 Feb 2008 10:05:43 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JM2tB-0004Md-KL for grub-devel@gnu.org; Mon, 04 Feb 2008 10:05:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JM2t9-0004Jy-UJ for grub-devel@gnu.org; Mon, 04 Feb 2008 10:05:41 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JM2t9-0004Jj-P9 for grub-devel@gnu.org; Mon, 04 Feb 2008 10:05:39 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JM2t9-00051R-NE for grub-devel@gnu.org; Mon, 04 Feb 2008 10:05:39 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JM2t8-0005tW-1u; Mon, 04 Feb 2008 16:05:38 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JM2rY-0003NJ-15; Mon, 04 Feb 2008 16:04:00 +0100 Date: Mon, 4 Feb 2008 16:04:00 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080204150400.GA12876@thorin> References: <4795B435.20102@leat.rub.de> <20080122124642.GC2017@thorin> <4795EC4D.5020207@leat.rub.de> <47A05477.5030300@leat.rub.de> <20080130194854.GA2143@thorin> <47A1877D.7020009@leat.rub.de> <20080131115855.GA13960@thorin> <47A6D04E.4070106@leat.rub.de> <20080204141837.GB7432@thorin> <47A7257E.1090807@leat.rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47A7257E.1090807@leat.rub.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: 462218@bugs.debian.org, Otavio Salvador Subject: Re: Bug#461442: detection of other OSes in update-grub X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 15:05:41 -0000 On Mon, Feb 04, 2008 at 03:47:26PM +0100, Fabian Greffrath wrote: > Robert Millan schrieb: > >Why is that a problem? > > > > Because foobar is not a block device, but grub-probe claims that it will > print a device if '--target=device' is given. Uhm I'm not sure if that's a good thing or may be overkill. What does everyone else think about this? > >I know that the call to probe() is not supposed to be reentrant, but I'd > >prefer not to break reentrancy if it can be easily avoided; it is possible > >that probe() needs to recurse onto itself in the future (because of > >RAID/LVM). > > > > OK, but should I keep it uninitialized? Depends on what you want to do ;-) > >Is it possible to share code with 10_linux.in here? > > > > Only if os-prober is installed. But then, os-prober does not check for > kernels on / and /target. What I mean is that 10_linux.in already has code that probes for stuff like Linux images and initrd files, and it might be a good idea to use the same logic. Or does os-prober provide any additional feature/knowledge about this? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)