All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "しらいしななこ " <nanako3@bluebottle.com>,
	"Jari Aalto" <jari.aalto@cante.net>,
	git@vger.kernel.org
Subject: Re: rebase -i and --whitespace, was Re: [PATCH] git-rebase.sh: Update USAGE string (No. 1)
Date: Mon, 4 Feb 2008 16:42:50 +0100	[thread overview]
Message-ID: <200802041642.52088.jnareb@gmail.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0802041505230.7372@racer.site>

W poniedziałek 4. lutego 2008 16:06, Johannes Schindelin napisał:
> On Mon, 4 Feb 2008, しらいしななこ wrote:
> 
> > I tried to run "git rebase --interactive --whitespace=strip" but it does 
> > not seem to strip blank characters at the end of my lines.  Did I find a 
> > bug?
> 
> Yes.  Interactive rebase never bothered with --whitespace options, since 
> it works purely with cherry-pick (the --merge option to non-interactive 
> rebase).  Therefore, the operation is not patch based, and does not call 
> git-apply at all (which would handle the whitespace).

So it means that synopsis should, instead of current (pre-patch)

'git-rebase' [-i | --interactive] [-v | --verbose] [-m | --merge]
        [-C<n>] [ --whitespace=<option>] [-p | --preserve-merges]
        [--onto <newbase>] <upstream> [<branch>]

should read

'git-rebase' [-v | --verbose]  [-p | --preserve-merges]
        [{-i | --interactive} | [-C<n>] [ --whitespace=<option>] [-m | --merge]]
        [--onto <newbase>] <upstream> [<branch>]

or perhaps even separated into interactive / non-interactive merge?

-- 
Jakub Narebski
Poland

  reply	other threads:[~2008-02-04 15:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 20:19 [PATCH] git-rebase.sh: Update USAGE string Jari Aalto
2008-02-03 21:14 ` Jakub Narebski
2008-02-03 23:33 ` [PATCH] git-rebase.sh: Update USAGE string (No. 1) Jari Aalto
2008-02-03 23:41   ` Johannes Schindelin
2008-02-03 23:52   ` Jakub Narebski
2008-02-04  0:11     ` Jari Aalto
2008-02-04  0:27       ` Johannes Schindelin
2008-02-04  0:39       ` Junio C Hamano
2008-02-04 10:15         ` Jakub Narebski
2008-02-04 11:57           ` Mike Hommey
2008-02-04 12:53             ` Jakub Narebski
2008-02-04  0:24     ` Junio C Hamano
2008-02-04  8:04       ` [PATCH v3] git-rebase.sh: Update USAGE string Jari Aalto
2008-02-04 11:12     ` [PATCH] git-rebase.sh: Update USAGE string (No. 1) しらいしななこ
2008-02-04 15:06       ` rebase -i and --whitespace, was " Johannes Schindelin
2008-02-04 15:42         ` Jakub Narebski [this message]
2008-02-04 16:32           ` Johannes Schindelin
2008-02-05 23:43           ` Junio C Hamano
2008-02-06  1:00             ` Johannes Schindelin
2008-02-04  0:16 ` [PATCH v2] git-rebase.sh: Update USAGE string Jari Aalto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802041642.52088.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jari.aalto@cante.net \
    --cc=nanako3@bluebottle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.