From: Christoph Hellwig <hch@lst.de>
To: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Cc: dgc@sgi.com, xfs@oss.sgi.com, hch@infradead.org
Subject: Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head
Date: Mon, 4 Feb 2008 15:52:30 -0500 [thread overview]
Message-ID: <20080204205230.GA14084@lst.de> (raw)
In-Reply-To: <1202106488-31494-1-git-send-email-jeffpc@josefsipek.net>
On Mon, Feb 04, 2008 at 01:28:08AM -0500, Josef 'Jeff' Sipek wrote:
> Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
> ---
> This patch assumes you already have Dave Chinner's patch for
> xfsidbg_xlogitem and xfsidbg_xaildump is needed.
>
> Changes since V1:
>
> - Pass around a pointer to the AIL, not the struct list_head
> - Make sure things compile & run with CONFIG_XFS_DEBUG
Does it work with XFS_TRANS_DEBUG defined aswell?
> - lip = xfs_ail_min(&(mp->m_ail.xa_ail));
> + lip = xfs_ail_min(&(mp->m_ail));
Care to remove these useless braces in all the places you touch while you're at it?
next prev parent reply other threads:[~2008-02-04 20:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 0:35 [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head Josef 'Jeff' Sipek
2008-01-21 4:04 ` Christoph Hellwig
2008-01-21 4:07 ` Josef 'Jeff' Sipek
2008-01-25 7:08 ` David Chinner
2008-01-25 7:36 ` Josef 'Jeff' Sipek
2008-02-04 6:28 ` Josef 'Jeff' Sipek
2008-02-04 20:52 ` Christoph Hellwig [this message]
2008-02-04 23:39 ` Josef 'Jeff' Sipek
2008-02-06 4:44 ` Josef 'Jeff' Sipek
2008-02-22 6:24 ` Josef 'Jeff' Sipek
2008-01-21 4:12 ` David Chinner
2008-01-21 6:54 ` Christoph Hellwig
2008-01-21 7:10 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080204205230.GA14084@lst.de \
--to=hch@lst.de \
--cc=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=jeffpc@josefsipek.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.