From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JM9oM-00011j-O7 for mharc-grub-devel@gnu.org; Mon, 04 Feb 2008 17:29:10 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JM9oI-0000zr-Jt for grub-devel@gnu.org; Mon, 04 Feb 2008 17:29:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JM9oH-0000yq-2W for grub-devel@gnu.org; Mon, 04 Feb 2008 17:29:06 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JM9oG-0000yk-QL for grub-devel@gnu.org; Mon, 04 Feb 2008 17:29:04 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JM9oG-0005Vz-Ni for grub-devel@gnu.org; Mon, 04 Feb 2008 17:29:04 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JM9oD-0006hk-JU for grub-devel@gnu.org; Mon, 04 Feb 2008 23:29:03 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JM9mS-0007OS-KL for grub-devel@gnu.org; Mon, 04 Feb 2008 23:27:12 +0100 Date: Mon, 4 Feb 2008 23:27:12 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080204222712.GA28299@thorin> References: <1202074413.560.7.camel@k9.localnet> <874pco90mm.fsf@xs4all.nl> <1202156471.582.11.camel@k9.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1202156471.582.11.camel@k9.localnet> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] to make grub2 compile on NetBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 22:29:07 -0000 On Mon, Feb 04, 2008 at 12:21:11PM -0800, walt wrote: > > On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote: > > walt writes: > > > > > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, > > > but this is useless for a free-standing executable like grub. Define > > > a dummy function in lieu of libgcc to supply __enable_execute_stack. > > > ... If this is for NetBSD only, > > shouldn't you add a #ifdef instead of a comment? > > Second try: > > Make NetBSD's gcc happy. > > * kern/mm.c: New dummy symbol __enable_execute_stack. > (include/grub/mm.h): Likewise. This ChangeLog entry seems wrong. I'll write it up for you, as it's easier to explain with an example: Make NetBSD's gcc happy. * include/grub/mm.h [__NetBSD__] (__enable_execute_stack): New function prototype. * kern/mm.c [__NetBSD__] (__enable_execute_stack): New function. > +#ifdef __NetBSD__ > +/* Dummy symbol to make gcc happy. */ > +void > +__enable_execute_stack(void) Missing space here ^ -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)