From: Marc Pignat <marc.pignat@hevs.ch>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Pierre Ossman <drzeus-mmc@drzeus.cx>,
David Brownell <david-b@pacbell.net>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH] at91_mci: use generic GPIO calls
Date: Tue, 5 Feb 2008 10:53:32 +0100 [thread overview]
Message-ID: <200802051053.33105.marc.pignat@hevs.ch> (raw)
In-Reply-To: <47A74790.50207@atmel.com>
Hi all!
On Monday 04 February 2008, Nicolas Ferre wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
...
> /*
> @@ -946,9 +986,10 @@ static int __exit at91_mci_remove(struct
> host = mmc_priv(mmc);
>
> if (host->board->det_pin) {
> + if (device_can_wakeup(&pdev->dev))
> + free_irq(gpio_to_irq(host->board->det_pin), host);
Seems strange to use device_can_wakeup(&pdev->dev) as
have_we_requested_this_irq(gpio_to_irq(host->board->det_pin))... but seems to
work.
Regards
Marc
next prev parent reply other threads:[~2008-02-05 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200802011901.27532.david-b@pacbell.net>
2008-02-04 17:12 ` [PATCH] at91_mci: use generic GPIO calls Nicolas Ferre
2008-02-05 9:53 ` Marc Pignat [this message]
2008-02-05 10:07 ` David Brownell
2008-02-07 17:10 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802051053.33105.marc.pignat@hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=david-b@pacbell.net \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.