From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] x86_emulate: fix side-effect macro call
Date: Tue, 5 Feb 2008 15:37:22 +0000
Message-ID: <20080205153722.GG4322@implementation.uk.xensource.com>
References: <20080205153355.GA10999@implementation.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20080205153355.GA10999@implementation.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Samuel Thibault, le Tue 05 Feb 2008 15:33:55 +0000, a écrit :
> x86_emulate: fix side-effect macro call
> Both jmp_rel and insn_fetch_type increment eip, so it's not
> compiler-safe to nest the calls.

Another way to fix it would be to change jmp_rel:

- _regs.eip += (int)(rel);
+ int _rel = (int)(rel);
+ _regs.eip += _rel;

Samuel