From: Pavel Machek <pavel@ucw.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jiri Kosina <jkosina@suse.cz>,
kernel list <linux-kernel@vger.kernel.org>,
Abel Bernabeu <abel.bernabeu@gmail.com>,
Hugh Dickins <hugh@veritas.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: brk randomization breaks columns
Date: Tue, 5 Feb 2008 23:04:31 +0100 [thread overview]
Message-ID: <20080205220431.GC1630@elf.ucw.cz> (raw)
In-Reply-To: <20080205160913.GB28812@elte.hu>
On Tue 2008-02-05 17:09:13, Ingo Molnar wrote:
>
> * Pavel Machek <pavel@ucw.cz> wrote:
>
> > > From: Jiri Kosina <jkosina@suse.cz>
> > >
> > > brk: check the lower bound properly
> > >
> > > There is a check in sys_brk(), that tries to make sure that we do not
> > > underflow the area that is dedicated to brk heap.
> > >
> > > The check is however wrong, as it assumes that brk area starts immediately
> > > after the end of the code (+bss), which is wrong for example in
> > > environments with randomized brk start. The proper way is to check whether
> > > the address is not below the start_brk address.
> > >
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > ACK.
>
> actually, does the patch above from Jiri solve the problem with your 11
> year old binaries too? (Sorry if it has been mentioned elsewhere, i
> could not decode it from this thread.)
No, it should just make the problem more obvious...
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-02-05 22:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 12:28 brk randomization breaks columns Pavel Machek
2008-02-04 13:01 ` Ingo Molnar
2008-02-04 13:28 ` Pavel Machek
2008-02-04 14:55 ` Jiri Kosina
2008-02-04 20:25 ` Pavel Machek
2008-02-04 14:33 ` Jiri Kosina
2008-02-04 16:12 ` Jiri Kosina
[not found] ` <15577be70802041016m97cddbfk43b9073408bcbce9@mail.gmail.com>
[not found] ` <15577be70802041029o2975ba6do34589bbdc81d1652@mail.gmail.com>
2008-02-04 19:52 ` Fwd: " Pavel Machek
2008-02-04 21:54 ` Abel Bernabeu
2008-02-04 22:48 ` Jiri Kosina
2008-02-04 23:13 ` Abel Bernabeu
2008-02-04 23:39 ` Pavel Machek
2008-02-04 20:31 ` Pavel Machek
2008-02-05 1:57 ` Jiri Kosina
2008-02-05 11:06 ` [regression] " Pavel Machek
2008-02-05 12:50 ` Jiri Kosina
2008-02-05 12:54 ` Ingo Molnar
2008-02-05 13:05 ` Jakub Jelinek
2008-02-05 16:18 ` Pavel Machek
2008-02-05 16:37 ` Ingo Molnar
2008-02-05 16:12 ` Pavel Machek
2008-02-05 13:08 ` Hugh Dickins
2008-02-05 15:00 ` Arjan van de Ven
2008-02-05 15:46 ` Pavel Machek
2008-02-05 15:49 ` Jiri Kosina
2008-02-05 15:55 ` Pavel Machek
2008-02-05 15:49 ` Ingo Molnar
2008-02-05 15:59 ` Pavel Machek
2008-02-05 16:06 ` Ingo Molnar
2008-02-05 22:03 ` Pavel Machek
2008-02-05 16:58 ` Arjan van de Ven
2008-02-05 17:33 ` Pavel Machek
2008-02-05 22:35 ` Jiri Kosina
2008-02-06 3:24 ` Randy Dunlap
2008-02-05 16:02 ` Pavel Machek
2008-02-05 16:09 ` Ingo Molnar
2008-02-05 22:04 ` Pavel Machek [this message]
2008-02-05 18:05 ` Pavel Machek
2008-02-05 20:42 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080205220431.GC1630@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=abel.bernabeu@gmail.com \
--cc=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.