From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMY7X-00034I-KG for mharc-grub-devel@gnu.org; Tue, 05 Feb 2008 19:26:35 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMY7W-000349-CE for grub-devel@gnu.org; Tue, 05 Feb 2008 19:26:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMY7U-00033h-Kd for grub-devel@gnu.org; Tue, 05 Feb 2008 19:26:33 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMY7U-00033e-Ew for grub-devel@gnu.org; Tue, 05 Feb 2008 19:26:32 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMY7U-0006hk-9B for grub-devel@gnu.org; Tue, 05 Feb 2008 19:26:32 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JMY7R-0000xc-3e for grub-devel@gnu.org; Wed, 06 Feb 2008 01:26:31 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JMY5f-0002bG-D5 for grub-devel@gnu.org; Wed, 06 Feb 2008 01:24:39 +0100 Date: Wed, 6 Feb 2008 01:24:39 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080206002439.GC2704@thorin> References: <47A8EB0D.6070103@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47A8EB0D.6070103@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 00:26:34 -0000 Hi Christian, On Wed, Feb 06, 2008 at 12:02:37AM +0100, Christian Franke wrote: > Two issues found in current CVS: > > 1. Booting a grub2-mkrescue floppy crashes if > "(memdisk)/boot/grub/grub.cfg" does not exist. This is because > grub_cpio_open does not set grub_errno if a file does not exist. I can't reproduce this with qemu: ./grub-mkrescue --pkglibdir=`pwd` --grub-mkimage=`pwd`/grub-mkimage --image-type=floppy /tmp/grub-rescue-floppy.img qemu -fda /tmp/grub-rescue-floppy.img -boot a is this supposed to be a spurious problem? > 2008-02-05 Christian Franke > > * fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE > and (*ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on last I would suggest "(and set *ofs = 0)" here to make it clearer. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)