All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dhaval Giani <dhaval@linux.vnet.ibm.com>
To: Oliver Pinter <oliver.pntr@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	stable@kernel.org, stable-commits@vger.kernel.org,
	Christoph Lameter <clameter@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	"chrisw@sous-sol.org" <chrisw@sous-sol.org>,
	Willy Tarreau <w@1wt.eu>, Adrian Bunk <bunk@kernel.org>
Subject: Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
Date: Wed, 6 Feb 2008 11:32:56 +0530	[thread overview]
Message-ID: <20080206060256.GA3836@linux.vnet.ibm.com> (raw)
In-Reply-To: <6101e8c40802051306y24cc7740g4c75508035aaefd@mail.gmail.com>

On Tue, Feb 05, 2008 at 10:06:02PM +0100, Oliver Pinter wrote:
> it is already im queue for 2.6.23,
> 
> ----8<-----
> >From stable-bounces@linux.kernel.org Sat Dec 22 14:04:08 2007
> From: Christoph Lameter <clameter@sgi.com>
> Date: Sat, 22 Dec 2007 14:03:23 -0800
> Subject: quicklists: do not release off node pages early
> To: torvalds@linux-foundation.org
> Cc: stable@kernel.org, akpm@linux-foundation.org,
> dhaval@linux.vnet.ibm.com, clameter@sgi.com
> Message-ID: <200712222203.lBMM3Nsk021922@imap1.linux-foundation.org>
> 
> 
> From: Christoph Lameter <clameter@sgi.com>
> 
> patch ed367fc3a7349b17354c7acef551533337764859 in mainline.
> 
> quicklists must keep even off node pages on the quicklists until the TLB
> flush has been completed.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> ---
>  include/linux/quicklist.h |    8 --------
>  1 file changed, 8 deletions(-)
> 
> --- a/include/linux/quicklist.h
> +++ b/include/linux/quicklist.h
> @@ -56,14 +56,6 @@ static inline void __quicklist_free(int
>  	struct page *page)
>  {
>  	struct quicklist *q;
> -	int nid = page_to_nid(page);
> -
> -	if (unlikely(nid != numa_node_id())) {
> -		if (dtor)
> -			dtor(p);
> -		__free_page(page);
> -		return;
> -	}
> 
>  	q = &get_cpu_var(quicklist)[nr];
>  	*(void **)p = q->page;
> 
> ---->8------
> Tested-by: Oliver Pinter <oliver.pntr@gmail.com> (on i386)
> 

Christoph,

Is this one also supposed to be backported?

-- 
regards,
Dhaval

  reply	other threads:[~2008-02-06  6:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 21:06 {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed Oliver Pinter
2008-02-06  6:02 ` Dhaval Giani [this message]
2008-02-06  6:30   ` Oliver Pinter
2008-02-06 18:58     ` Christoph Lameter
2008-02-06 18:58   ` Christoph Lameter
2008-02-06 19:06     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206060256.GA3836@linux.vnet.ibm.com \
    --to=dhaval@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=chrisw@sous-sol.org \
    --cc=clameter@sgi.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver.pntr@gmail.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.