From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMj0T-0001DQ-Ex for mharc-grub-devel@gnu.org; Wed, 06 Feb 2008 07:04:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMj0R-0001DC-UT for grub-devel@gnu.org; Wed, 06 Feb 2008 07:03:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMj0R-0001Cz-4v for grub-devel@gnu.org; Wed, 06 Feb 2008 07:03:59 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMj0Q-0001Cw-VI for grub-devel@gnu.org; Wed, 06 Feb 2008 07:03:58 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMj0Q-0001yW-OJ for grub-devel@gnu.org; Wed, 06 Feb 2008 07:03:58 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JMj0O-0001x1-0y for grub-devel@gnu.org; Wed, 06 Feb 2008 13:03:57 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JMiya-0005lO-3n for grub-devel@gnu.org; Wed, 06 Feb 2008 13:02:04 +0100 Date: Wed, 6 Feb 2008 13:02:04 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080206120204.GA22114@thorin> References: <47A9881C.70908@leat.rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47A9881C.70908@leat.rub.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Bug#461442: detection of other OSes in update-grub X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 12:04:00 -0000 On Wed, Feb 06, 2008 at 11:12:44AM +0100, Fabian Greffrath wrote: > I do not believe this is an overkill. Do you want grub-probe to print > "i-dont-check-my-arguments" (grub-probe --target=device --device > i-dont-check-my-arguments) ? > Even worse, if you select another target than 'device' and if you don't > check if the given parameter is *really* a device name, you will pass > the faulty parameter over to the other functions that are called in > probe () and fail with some "cannot stat ..." message . In my opinion > this should not happen. Instead, grub-probe should fail gracefully with > a dedicated error messge in this situation as proposed by my patch. Ok, I don't mind that much. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)