All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russ Anderson <rja@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] Fix large MCA bootmem allocation
Date: Wed, 06 Feb 2008 15:13:33 +0000	[thread overview]
Message-ID: <20080206151332.GA6129@sgi.com> (raw)
In-Reply-To: <20080205193232.GA8834@sgi.com>

On Tue, Feb 05, 2008 at 04:00:09PM -0800, Luck, Tony wrote:
> > Given that ia64_mca_cpu_init() does not get called in
> > the hot-plug path
> 
> Surely it must be ...

That's what I thought, until testing showed otherwise.

The two code paths are setup_arch->cpu_init->ia64_mca_cpu_init
for the boot processor and 
start_secondary->cpu_init->ia64_mca_cpu_init for the other cpus
at boot time.

>                        you even have code in it to cope
> with this case.  The:
> 
> 	if (__per_cpu_mca[cpu]) {
> 
> test can only be true if we are back in this code for a
> second run through if the cpu was taken offline and added
> again. Just like it says in the comment above this test.

Written on the assumption that the hot-plug code would
eventually call it. 

-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@sgi.com

  parent reply	other threads:[~2008-02-06 15:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 19:32 [patch] Fix large MCA bootmem allocation Russ Anderson
2008-02-05 20:21 ` Bjorn Helgaas
2008-02-05 23:12 ` Russ Anderson
2008-02-05 23:24 ` Bjorn Helgaas
2008-02-05 23:54 ` Luck, Tony
2008-02-05 23:54 ` Russ Anderson
2008-02-06  0:00 ` Luck, Tony
2008-02-06  0:30 ` Hidetoshi Seto
2008-02-06  1:34 ` Robin Holt
2008-02-06  2:23 ` Hidetoshi Seto
2008-02-06  3:50 ` Hidetoshi Seto
2008-02-06 10:44 ` Robin Holt
2008-02-06 12:39 ` Hidetoshi Seto
2008-02-06 13:22 ` Robin Holt
2008-02-06 15:13 ` Russ Anderson [this message]
2008-02-06 23:32 ` Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206151332.GA6129@sgi.com \
    --to=rja@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.