From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reduce large do_mount stack usage with noinlines
Date: Wed, 6 Feb 2008 15:22:39 -0800 [thread overview]
Message-ID: <20080206152239.a2352d6d.akpm@linux-foundation.org> (raw)
In-Reply-To: <47AA3EAA.9080204@redhat.com>
On Wed, 06 Feb 2008 17:11:38 -0600
Eric Sandeen <sandeen@redhat.com> wrote:
> /*
> * recursively change the type of the mountpoint.
> + * noinline this do_mount helper to save do_mount stack space.
> */
> -static int do_change_type(struct nameidata *nd, int flag)
> +static noinline int do_change_type(struct nameidata *nd, int flag)
What we could do here is defined a new noinline_because_of_stack_suckiness
and use that. Reasons:
- self-documenting, so we don't need to comment each site
- can be made a no-op for suitable __GNUC__ values if gcc ever fixes this
- our children we can go through and delete them all when nobody is using
the offending gcc versions any more.
what thinkest thou?
next prev parent reply other threads:[~2008-02-06 23:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 22:13 [PATCH] reduce large do_mount stack usage with noinlines Eric Sandeen
2008-02-06 22:34 ` Andrew Morton
2008-02-06 22:54 ` Arjan van de Ven
2008-02-06 23:01 ` Eric Sandeen
2008-02-06 22:55 ` Eric Sandeen
2008-02-06 23:11 ` Eric Sandeen
2008-02-06 23:22 ` Andrew Morton [this message]
2008-02-06 23:34 ` Eric Sandeen
2008-02-06 23:46 ` Andrew Morton
2008-02-07 23:08 ` Eric Sandeen
2008-02-07 23:23 ` Arjan van de Ven
2008-02-07 23:26 ` Andrew Morton
2008-02-08 16:50 ` Andi Kleen
2008-02-08 16:54 ` Eric Sandeen
2008-02-08 17:23 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206152239.a2352d6d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.