From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMmHq-0002RH-5W for mharc-grub-devel@gnu.org; Wed, 06 Feb 2008 10:34:10 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMmHn-0002Pz-6F for grub-devel@gnu.org; Wed, 06 Feb 2008 10:34:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMmHk-0002PU-Vx for grub-devel@gnu.org; Wed, 06 Feb 2008 10:34:06 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMmHk-0002PL-Tn for grub-devel@gnu.org; Wed, 06 Feb 2008 10:34:04 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMmHk-0005Jy-7M for grub-devel@gnu.org; Wed, 06 Feb 2008 10:34:04 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JMmHh-0002Kk-4f for grub-devel@gnu.org; Wed, 06 Feb 2008 16:34:03 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JMmG0-00084g-1F for grub-devel@gnu.org; Wed, 06 Feb 2008 16:32:16 +0100 Date: Wed, 6 Feb 2008 16:32:16 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080206153215.GA30816@thorin> References: <87myqvzkqk.fsf@xs4all.nl> <20080124143306.GB8248@thorin> <20080124145317.GA9385@thorin> <1201193272.334.2.camel@k9.localnet> <20080124171206.GA1515@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: booting kernel of NetBSD (Re: UFS (FFS) support seems broken in grub2) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 15:34:07 -0000 On Sat, Jan 26, 2008 at 11:01:49PM +0800, Bean wrote: > > * loader/i386/pc/multiboot.c (grub_multiboot_load_elf32): Get physical > address of entry. > (grub_multiboot_load_elf64): Likewise. > (grub_multiboot): Initialize mbi structure. > > > diff --git a/loader/i386/pc/multiboot.c b/loader/i386/pc/multiboot.c > index fa6346e..2fd2b24 100644 > --- a/loader/i386/pc/multiboot.c > +++ b/loader/i386/pc/multiboot.c > @@ -96,6 +96,7 @@ grub_multiboot_load_elf32 (grub_file_t file, void *buffer) > { > Elf32_Ehdr *ehdr = (Elf32_Ehdr *) buffer; > Elf32_Phdr *phdr; > + grub_addr_t real_entry = 0; I would suggest a more explicit name, like physical_entry_addr or so. That'd make it easier to understand without the context of your mail and changelog entry. > + grub_memset (mbi, 0, sizeof (struct grub_multiboot_info)); I wonder if it'd make sense to do this in grub_malloc(). This would save us from similar bugs in the future (and have the advantage that memory handling bugs would be exposed earlier). What do you think, is this idea too crazy? :-) (I would still add grub_memset here for now, though; makes no sense to delay it) -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)