From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMppC-00083q-4R for mharc-grub-devel@gnu.org; Wed, 06 Feb 2008 14:20:50 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMpp9-00082o-Mp for grub-devel@gnu.org; Wed, 06 Feb 2008 14:20:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMpp9-000829-0H for grub-devel@gnu.org; Wed, 06 Feb 2008 14:20:47 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMpp8-000823-Gp for grub-devel@gnu.org; Wed, 06 Feb 2008 14:20:46 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMpp8-0001SR-68 for grub-devel@gnu.org; Wed, 06 Feb 2008 14:20:46 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JMpp1-0002kB-3l for grub-devel@gnu.org; Wed, 06 Feb 2008 20:20:40 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JMpnI-00029y-KT for grub-devel@gnu.org; Wed, 06 Feb 2008 20:18:52 +0100 Date: Wed, 6 Feb 2008 20:18:52 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080206191852.GA7986@thorin> References: <47A8EB0D.6070103@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 19:20:48 -0000 On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote: > > This patch fixes both issues. > > Actually, the first version of grub_cpio_find_file returned > GRUB_ERR_FILE_NONE when the end of file is encounter, but then, > somebody find out that opening non existent file have problem, and the > result is changed to GRUB_ERR_FILE_NOT_FOUND. I guess it still have > problem, the fix you are providing seems ok. Christian doesn't have write perms. Bean, since you're more familiar with this code, will you check that in? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)