From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()
Date: Wed, 6 Feb 2008 21:43:18 +0100 [thread overview]
Message-ID: <200802062143.19121.bzolnier@gmail.com> (raw)
In-Reply-To: <47A9F78D.20904@ru.mvista.com>
On Wednesday 06 February 2008, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > Same BUG_ON() is present inside ide_set_handler().
>
> There is no BUG_ON there -- __ide_set_handler() has a check for the same
> condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()...
Yeah, you're right - care to make a patch?
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> MBR, Sergei
next prev parent reply other threads:[~2008-02-06 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 0:46 [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc() Bartlomiej Zolnierkiewicz
2008-02-06 18:08 ` Sergei Shtylyov
2008-02-06 20:43 ` Bartlomiej Zolnierkiewicz [this message]
2008-02-07 12:55 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802062143.19121.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.