From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMtHI-0002SG-CS for mharc-grub-devel@gnu.org; Wed, 06 Feb 2008 18:02:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMtHH-0002RN-5m for grub-devel@gnu.org; Wed, 06 Feb 2008 18:02:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMtHF-0002QJ-7Z for grub-devel@gnu.org; Wed, 06 Feb 2008 18:02:02 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMtHF-0002QE-0J for grub-devel@gnu.org; Wed, 06 Feb 2008 18:02:01 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMtHE-0003fj-Js for grub-devel@gnu.org; Wed, 06 Feb 2008 18:02:00 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JMtH7-00034i-CS for grub-devel@gnu.org; Thu, 07 Feb 2008 00:01:54 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JMtFC-0004TS-EH for grub-devel@gnu.org; Wed, 06 Feb 2008 23:59:54 +0100 Date: Wed, 6 Feb 2008 23:59:54 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080206225954.GA17090@thorin> References: <20080206164507.GA3287@thorin> <87bq6thfj8.wl@dekkers.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87bq6thfj8.wl@dekkers.cx> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] simplify grub_raid_array X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 23:02:03 -0000 On Wed, Feb 06, 2008 at 11:43:39PM +0100, Jeroen Dekkers wrote: > At Wed, 6 Feb 2008 17:45:07 +0100, > Robert Millan wrote: > > Unless I missed something, it seems that grub_raid_array contains redundant > > information (`name' is already present via `disk->name'). I propose to > > simplify it this way. > > No idea why, I don't have the time to look at the actual code, but > > > @@ -410,7 +410,7 @@ grub_raid_scan_device (const char *name) > > return 0; > > } > > > > - if (array->device[sb.this_disk.number].name != 0) > > + if (array->device[sb.this_disk.number]->name != 0) > > { > > /* We found multiple devices with the same number. Again, > > this shouldn't happen.*/ > > looks suspicious to me. Is that really doing what it is meant to do? Yes. `array->device[sb.this_disk.number]' used to be: struct { char *name; grub_disk_t disk; } and it becomes grub_disk_t, which is: struct { char *name; other stuff; } * this is tested in runtime. My concern was more about whether both `name' instances could have different meaning or so. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)