All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: melgor@ie.ibm.com
Cc: apw@shadowen.org, clameter@sgi.com, agl@us.ibm.com,
	wli@holomorphy.com, linux-mm@kvack.org
Subject: [RFC][PATCH 2/2] Explicitly retry hugepage allocations
Date: Wed, 6 Feb 2008 15:12:43 -0800	[thread overview]
Message-ID: <20080206231243.GG3477@us.ibm.com> (raw)
In-Reply-To: <20080206230726.GF3477@us.ibm.com>

Add __GFP_REPEAT to hugepage allocations. Do so to not necessitate
userspace putting pressure on the VM by repeated echo's into
/proc/sys/vm/nr_hugepages to grow the pool. With the previous patch to
allow for large-order __GFP_REPEAT attempts to loop for a bit (as
opposed to indefinitely), this increases the likelihood of getting
hugepages when the system experiences (or recently experienced) load.

On a 2-way x86_64, this doubles the number of hugepages (from 10 to 20)
obtained while compiling a kernel at the same time. On a 4-way ppc64,
a similar scale increase is seen (from 3 to 5 hugepages). Finally, on a
2-way x86, this leads to a 5-fold increase in the hugepages allocatable
under load (90 to 554).

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 1a56420..0358a91 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -176,7 +176,8 @@ static struct page *alloc_fresh_huge_page_node(int nid)
 	struct page *page;
 
 	page = alloc_pages_node(nid,
-		htlb_alloc_mask|__GFP_COMP|__GFP_THISNODE|__GFP_NOWARN,
+		htlb_alloc_mask|__GFP_COMP|__GFP_THISNODE|
+						__GFP_REPEAT|__GFP_NOWARN,
 		HUGETLB_PAGE_ORDER);
 	if (page) {
 		set_compound_page_dtor(page, free_huge_page);
@@ -262,7 +263,8 @@ static struct page *alloc_buddy_huge_page(struct vm_area_struct *vma,
 	}
 	spin_unlock(&hugetlb_lock);
 
-	page = alloc_pages(htlb_alloc_mask|__GFP_COMP|__GFP_NOWARN,
+	page = alloc_pages(htlb_alloc_mask|__GFP_COMP|
+					__GFP_REPEAT|__GFP_NOWARN,
 					HUGETLB_PAGE_ORDER);
 
 	spin_lock(&hugetlb_lock);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-02-06 23:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 23:07 [RFC][PATCH 1/2] Smarter retry of costly-order allocations Nishanth Aravamudan
2008-02-06 23:12 ` Nishanth Aravamudan [this message]
2008-02-06 23:30   ` [RFC][PATCH 2/2] Explicitly retry hugepage allocations Christoph Lameter
2008-02-07  1:04     ` Nishanth Aravamudan
2008-02-08 17:11     ` Nishanth Aravamudan
2008-02-08 19:19       ` Christoph Lameter
2008-02-08 23:40         ` Nishanth Aravamudan
2008-02-08 23:42           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206231243.GG3477@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=agl@us.ibm.com \
    --cc=apw@shadowen.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=melgor@ie.ibm.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.