From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [NFS] [PATCH] Make UDF exportable Date: Wed, 6 Feb 2008 22:37:51 -0500 Message-ID: <20080207033751.GA26792@infradead.org> References: <1201726404.2976.8.camel@localhost.localdomain> <20080205102955.GA28347@infradead.org> <1202233464.12188.43.camel@localhost.localdomain> <20080206180850.GD3475@duck.suse.cz> <1202331482.2727.8.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Christoph Hellwig , nfs@lists.sourceforge.net, linux-fsdevel@vger.kernel.org To: Rasmus Rohde Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:58126 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753334AbYBGDhz (ORCPT ); Wed, 6 Feb 2008 22:37:55 -0500 Content-Disposition: inline In-Reply-To: <1202331482.2727.8.camel@localhost.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Feb 06, 2008 at 09:58:02PM +0100, Rasmus Rohde wrote: > Probably not. I just tested that I could read files and navigate the > directory structure. However looking into UDF I think you are right - it > will fail. > I have extended udf_find_entry() to do an explicit check based on > fileCharacteristics as you propose. > How do I actually test this case? Testing this is pretty hard. You export a filesystem, then cd somewhere deep into a directory hiearchy in there. Then unexport the filesystem and unmount on the server. mount it back on the server, export it again and do something with a file from the directory you've cd into before the unmount. Make sure you have a printk in your get_parent method to make sure you're really hitting it. Btw, I think it would be nicer to opencode the .. lookup in get_parent instead of changing udf_find_entry. The lookup for .. is not needed by anything else, and get_parent only looks for it so it's a natural place to opencode it there.