All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: partition sysfs OOPS in current GIT
Date: Wed, 6 Feb 2008 22:44:07 -0800	[thread overview]
Message-ID: <20080207064407.GA22963@suse.de> (raw)
In-Reply-To: <20080206.220544.238067538.davem@davemloft.net>

On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Wed, 6 Feb 2008 21:47:38 -0800
> 
> > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote:
> > > I redid the bisect to make sure it absolutely was that specific
> > > changeset, and it is.
> > 
> > Thanks for doing that, I'll let you know when I have a patch to test.
> 
> I found the problem, it's the "whole_disk" partition attribute.
> 
> Look in fs/partitions/check.c:add_partition() where it tests the
> ADDPART_FLAG_WHOLEDISK flag.

So, if you just comment out that whole "if (flags &
ADDPART_FLAG_WHOLEDISK)" chunk, does the oops go away?  I think that is
the real solution here as I don't see what this attribute is supposed to
be showing.

thanks,

greg k-h

  parent reply	other threads:[~2008-02-07  6:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 23:26 partition sysfs OOPS in current GIT David Miller
2008-02-06 23:31 ` Greg KH
2008-02-06 23:37   ` David Miller
2008-02-06 23:48     ` David Miller
2008-02-06 23:59     ` Greg KH
2008-02-07  0:02       ` David Miller
2008-02-07  0:09         ` Greg KH
2008-02-07  0:29           ` David Miller
2008-02-07  4:06           ` David Miller
2008-02-07  5:47             ` Greg KH
2008-02-07  6:05               ` David Miller
2008-02-07  6:38                 ` Greg KH
2008-02-07  6:38                   ` David Miller
2008-02-07  6:42                 ` Greg KH
2008-02-07  6:39                   ` David Miller
2008-02-07  6:58                     ` Greg KH
2008-02-07  7:00                     ` Greg KH
2008-02-07  7:11                       ` David Miller
2008-02-07  7:18                         ` Greg KH
2008-02-07  7:33                           ` David Miller
2008-02-07  7:43                             ` Greg KH
2008-02-07  7:20                         ` Greg KH
2008-02-07  7:24                           ` David Miller
2008-02-07  7:42                             ` Greg KH
2008-02-07  6:44                 ` Greg KH [this message]
2008-02-07  6:42                   ` David Miller
2008-02-06 23:57   ` Andrew Morton
2008-02-07  0:07     ` Greg KH
2008-02-06 23:42 ` Oops figures Jan Engelhardt
2008-02-06 23:42   ` Jan Engelhardt
2008-02-06 23:47   ` David Miller
2008-02-06 23:47     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207064407.GA22963@suse.de \
    --to=gregkh@suse.de \
    --cc=davem@davemloft.net \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.